Avoid unnecessary JS call in _emscripten_next_timer. NFC (#26695)

sbc100 · web-flow · commit 91c0580b0719 · 2026-04-16T01:50:16.000Z
diff --git a/system/lib/libc/musl/src/signal/setitimer.c b/system/lib/libc/musl/src/signal/setitimer.c
@@ -90,7 +90,11 @@ double _emscripten_next_timer()
 			next_timer = fmin(current_timeout_ms[which], next_timer);
 		}
 	}
-	return next_timer - emscripten_get_now();
+	// Avoid calling emscripten_get_now() unless we need to here.
+	if (next_timer != INFINITY) {
+		next_timer -= emscripten_get_now();
+	}
+	return next_timer;
 }
 #endif
 
diff --git a/test/codesize/test_codesize_hello_dylink_all.json b/test/codesize/test_codesize_hello_dylink_all.json
@@ -1,7 +1,7 @@
 {
   "a.out.js": 244278,
-  "a.out.nodebug.wasm": 577639,
-  "total": 821917,
+  "a.out.nodebug.wasm": 577664,
+  "total": 821942,
   "sent": [
     "IMG_Init",
     "IMG_Load",

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,11 @@ double _emscripten_next_timer()`
`90`	`90`	`next_timer = fmin(current_timeout_ms[which], next_timer);`
`91`	`91`	`}`
`92`	`92`	`}`
`93`		`- return next_timer - emscripten_get_now();`
	`93`	`+ // Avoid calling emscripten_get_now() unless we need to here.`
	`94`	`+ if (next_timer != INFINITY) {`
	`95`	`+ next_timer -= emscripten_get_now();`
	`96`	`+ }`
	`97`	`+ return next_timer;`
`94`	`98`	`}`
`95`	`99`	`#endif`
`96`	`100`