Skip to content

Commit 991c0de

Browse files
authored
Require Firefox 109 for browser.test_webgl_get_uniform_no_active_program (#26901)
Require Firefox 109 for browser.test_webgl_get_uniform_no_active_program. https://bugzil.la/1645092 CC @vittorioromeo
1 parent 5fc3d5f commit 991c0de

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

test/test_browser.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
browser_should_skip_feature,
3131
find_browser_test_file,
3232
get_browser,
33+
get_firefox_version,
3334
get_safari_version,
3435
is_chrome,
3536
is_firefox,
@@ -176,6 +177,7 @@ def decorator(min_required_version, note=''):
176177

177178

178179
requires_safari_version = requires_version('safari', get_safari_version)
180+
requires_firefox_version = requires_version('firefox', get_firefox_version)
179181

180182

181183
def is_jspi(args):
@@ -1249,6 +1251,7 @@ def test_webgl_uniform_before_get_location(self, args):
12491251
'assertions': (['-sGL_ASSERTIONS'],),
12501252
})
12511253
@requires_webgl2
1254+
@requires_firefox_version(109) # Old Firefox failed to do glGetUniform(program, ...) if program was not active. https://bugzil.la/1645092
12521255
def test_webgl_get_uniform_no_active_program(self, args):
12531256
self.btest_exit('webgl_get_uniform_no_active_program.c', cflags=args + ['-sMIN_WEBGL_VERSION=2'])
12541257

0 commit comments

Comments
 (0)