[WasmFS] Fix absolute path access under NODERAWFS

Resolves: #24830.

Author: kleisauke

system/lib/wasmfs/backend.h

@@ -21,6 +21,8 @@ class Backend {
   virtual std::shared_ptr<Directory> createDirectory(mode_t mode) = 0;
   virtual std::shared_ptr<Symlink> createSymlink(std::string target) = 0;
 
+  virtual bool isVirtualized() { return true; }
+
   virtual ~Backend() = default;
 };
 

system/lib/wasmfs/backends/node_backend.cpp

@@ -180,6 +180,9 @@ class NodeDirectory : public Directory {
 
 private:
   std::string getChildPath(const std::string& name) {
+    if (state.path.empty()) {
+      return name;
+    }
     return state.path + '/' + name;
   }
 
@@ -294,6 +297,8 @@ class NodeBackend : public Backend {
   std::shared_ptr<Symlink> createSymlink(std::string target) override {
     WASMFS_UNREACHABLE("TODO: implement NodeBackend::createSymlink");
   }
+
+  virtual bool isVirtualized() override { return false; }
 };
 
 // TODO: symlink

system/lib/wasmfs/backends/noderawfs_root.cpp

@@ -6,5 +6,5 @@
 #include "emscripten/wasmfs.h"
 
 backend_t wasmfs_create_root_dir(void) {
-  return wasmfs_create_node_backend(".");
+  return wasmfs_create_node_backend("");
 }

system/lib/wasmfs/paths.cpp

@@ -66,12 +66,21 @@ ParsedParent doParseParent(std::string_view path,
                            size_t& recursions) {
   // Empty paths never exist.
   if (path.empty()) {
-    return {-ENOENT};
+    return -ENOENT;
+  }
+
+  auto root = wasmFS.getRootDirectory();
+
+  // If the root backend is not virtualized, we assume there is only a single
+  // backend, making parent traversal unnecessary. Simply return the current
+  // directory along with the full path.
+  if (!root->getBackend()->isVirtualized()) {
+    return {std::make_pair(std::move(curr), path)};
   }
 
   // Handle absolute paths.
   if (path.front() == '/') {
-    curr = wasmFS.getRootDirectory();
+    curr = root;
     path.remove_prefix(1);
   }
 
@@ -84,7 +93,7 @@ ParsedParent doParseParent(std::string_view path,
   // contain a child segment for us to return. The root is its own parent, so we
   // can handle this by returning (root, ".").
   if (path.empty()) {
-    return {std::make_pair(std::move(curr), std::string_view("."))};
+    return {std::make_pair(std::move(curr), ".")};
   }
 
   while (true) {

test/test_core.py

@@ -6151,9 +6151,12 @@ def test_unistd_unlink(self):
 
     # Several differences/bugs on non-linux including https://github.com/nodejs/node/issues/18014
     # TODO: NODERAWFS in WasmFS
-    if '-DNODERAWFS' in self.cflags and os.geteuid() == 0:
+    if '-DNODERAWFS' in self.cflags:
       # 0 if root user
-      self.cflags += ['-DSKIP_ACCESS_TESTS']
+      if os.geteuid() == 0:
+        self.cflags += ['-DSKIP_ACCESS_TESTS']
+      if self.get_setting('WASMFS'):
+        self.skipTest('https://github.com/emscripten-core/emscripten/issues/18112')
 
     self.do_runf('unistd/unlink.c', 'success')
 

test/test_other.py

@@ -9291,12 +9291,19 @@ def test_noderawfs_disables_embedding(self):
     self.assert_fail(base + ['--preload-file', 'somefile'], expected)
     self.assert_fail(base + ['--embed-file', 'somefile'], expected)
 
+  @crossplatform
+  @also_with_wasmfs
   def test_noderawfs_access_abspath(self):
     create_file('foo', 'bar')
     create_file('access.c', r'''
+      #include <stdio.h>
+      #include <assert.h>
       #include <unistd.h>
       int main(int argc, char** argv) {
-        return access(argv[1], F_OK);
+        printf("testing access to %s\n", argv[1]);
+        int rtn = access(argv[1], F_OK);
+        assert(rtn == 0);
+        return 0;
       }
     ''')
     self.do_runf('access.c', cflags=['-sNODERAWFS'], args=[os.path.abspath('foo')])
@@ -13254,11 +13261,10 @@ def test_unistd_chown(self):
     self.set_setting('WASMFS')
     self.do_run_in_out_file_test('wasmfs/wasmfs_chown.c')
 
-  @wasmfs_all_backends
   def test_wasmfs_getdents(self):
     # Run only in WASMFS for now.
     self.set_setting('FORCE_FILESYSTEM')
-    self.do_run_in_out_file_test('wasmfs/wasmfs_getdents.c')
+    self.do_run_in_out_file_test('wasmfs/wasmfs_getdents.c', cflags=['-sWASMFS'])
 
   def test_wasmfs_jsfile(self):
     self.set_setting('WASMFS')
@@ -13844,15 +13850,13 @@ def test_fs_icase(self):
   @crossplatform
   @with_all_fs
   def test_std_filesystem(self):
-    if self.get_setting('NODERAWFS') and self.get_setting('WASMFS'):
-      self.skipTest('https://github.com/emscripten-core/emscripten/issues/24830')
+    if (WINDOWS or MACOS) and self.get_setting('NODERAWFS') and self.get_setting('WASMFS'):
+      self.skipTest('fails with ENOTEMPTY (Directory not empty) during fs::remove_all')
     self.do_other_test('test_std_filesystem.cpp')
 
   @crossplatform
   @with_all_fs
   def test_std_filesystem_tempdir(self):
-    if self.get_setting('NODERAWFS') and self.get_setting('WASMFS'):
-      self.skipTest('https://github.com/emscripten-core/emscripten/issues/24830')
     self.do_other_test('test_std_filesystem_tempdir.cpp', cflags=['-g'])
 
   def test_strict_js_closure(self):