[tsgen] Quote non-identifier enum value names in module entry. (#26814)

`enum_value_type::string` (added in #25257) accepts arbitrary JS-facing
names via `.value("name", ...)`. The type union path quotes these
correctly as string literals, but `printModuleEntry` emits them as bare
object keys, producing invalid TypeScript when the name is not a valid
JS identifier.

```cpp
enum_<Foo>("Foo", enum_value_type::string).value("a-b", Foo::A);
```

Before:
```ts
Foo: { a-b: 'a-b' };  // bare hyphenated key — TS parser rejects
```

After:
```ts
Foo: { 'a-b': 'a-b' };
```

The same bare-key shape exists in all three `valueType` branches of
`printModuleEntry`. The convention in `object`/`number` modes is to use
C++ identifiers so the bug isn't reachable there in practice, but the
fix applies to all three for symmetry with `print`, which already
handles non-identifier names via string-literal quoting.

Author: soilSpoon

src/lib/libembind_gen.js

@@ -337,15 +337,17 @@ var LibraryEmbind = {
       out.push(`  ${this.name}: {`);
       const outItems = [];
       for (const [name, value] of this.items) {
+        // Quote keys that aren't valid JS identifiers.
+        const key = /^[a-zA-Z_$][\w$]*$/.test(name) ? name : `'${name}'`;
         switch (this.valueType) {
           case 'object':
-            outItems.push(`${name}: ${this.name}Value<${value}>`);
+            outItems.push(`${key}: ${this.name}Value<${value}>`);
             break;
           case 'number':
-            outItems.push(`${name}: ${value}`);
+            outItems.push(`${key}: ${value}`);
             break;
           case 'string':
-            outItems.push(`${name}: '${name}'`);
+            outItems.push(`${key}: '${name}'`);
             break;
         }
       }

test/other/embind_tsgen.cpp

@@ -58,6 +58,7 @@ std::unique_ptr<Test> class_unique_ptr_returning_fn() {
 enum FirstEnum { kValueOne, kValueTwo, kValueThree };
 enum SecondEnum { kValueA, kValueB, kValueC };
 enum ThirdEnum { kValueAlpha, kValueBeta, kValueGamma };
+enum HyphenatedEnum { kHyphenA, kHyphenB };
 enum EmptyEnum {};
 
 FirstEnum enum_returning_fn() { return kValueOne; }
@@ -215,6 +216,9 @@ EMSCRIPTEN_BINDINGS(Test) {
       .value("kValueAlpha", ThirdEnum::kValueAlpha)
       .value("kValueBeta", ThirdEnum::kValueBeta)
       .value("kValueGamma", ThirdEnum::kValueGamma);
+  enum_<HyphenatedEnum>("HyphenatedEnum", enum_value_type::string)
+      .value("k-hyphen-a", HyphenatedEnum::kHyphenA)
+      .value("k-hyphen-b", HyphenatedEnum::kHyphenB);
   enum_<EmptyEnum>("EmptyEnum");
 
   function("enum_returning_fn", &enum_returning_fn);

test/other/embind_tsgen.d.ts

@@ -40,6 +40,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -129,6 +131,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;

test/other/embind_tsgen_ignore_1.d.ts

@@ -51,6 +51,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -140,6 +142,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;

test/other/embind_tsgen_ignore_2.d.ts

@@ -39,6 +39,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -128,6 +130,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;

test/other/embind_tsgen_ignore_3.d.ts

@@ -40,6 +40,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -129,6 +131,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;

test/other/embind_tsgen_ignore_7.d.ts

@@ -40,6 +40,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -129,6 +131,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;

test/other/embind_tsgen_module.d.ts

@@ -40,6 +40,8 @@ export type SecondEnum = 0|1|2;
 
 export type ThirdEnum = 'kValueAlpha'|'kValueBeta'|'kValueGamma';
 
+export type HyphenatedEnum = 'k-hyphen-a'|'k-hyphen-b';
+
 export interface EmptyEnumValue<T extends number> {
   value: T;
 }
@@ -129,6 +131,7 @@ interface EmbindModule {
   FirstEnum: {kValueOne: FirstEnumValue<0>, kValueTwo: FirstEnumValue<1>, kValueThree: FirstEnumValue<2>};
   SecondEnum: {kValueA: 0, kValueB: 1, kValueC: 2};
   ThirdEnum: {kValueAlpha: 'kValueAlpha', kValueBeta: 'kValueBeta', kValueGamma: 'kValueGamma'};
+  HyphenatedEnum: {'k-hyphen-a': 'k-hyphen-a', 'k-hyphen-b': 'k-hyphen-b'};
   EmptyEnum: {};
   enum_returning_fn(): FirstEnum;
   num_enum_returning_fn(): SecondEnum;