Skip to content

Commit c93d8f6

Browse files
libwebsocket: add missing $webSockets dependency (#26318)
`emscripten_websocket_new` uses `$webSockets` but does not declare it as a dependency. Fixes: #26310
1 parent c01004b commit c93d8f6

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

src/lib/libwebsocket.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ var LibraryWebSocket = {
276276
},
277277

278278
emscripten_websocket_new__proxy: 'sync',
279+
emscripten_websocket_new__deps: ['$webSockets'],
279280
emscripten_websocket_new: (createAttributes) => {
280281
if (!globalThis.WebSocket) {
281282
#if WEBSOCKET_DEBUG

test/test_sockets.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,9 @@ def test_websocket_send(self, args):
395395
with NodeJsWebSocketEchoServerProcess():
396396
self.btest_exit('websocket/test_websocket_send.c', cflags=['-lwebsocket', '-sNO_EXIT_RUNTIME', '-sWEBSOCKET_DEBUG'] + args)
397397

398+
def test_websocket_new(self):
399+
self.btest_exit('websocket/test_websocket_new.c', cflags=['-lwebsocket'])
400+
398401
# Test that native POSIX sockets API can be used by proxying calls to an intermediate WebSockets
399402
# -> POSIX sockets bridge server
400403
@requires_shared_array_buffer
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#include <emscripten/websocket.h>
2+
#include <assert.h>
3+
4+
int main() {
5+
EMSCRIPTEN_WEBSOCKET_T s =
6+
emscripten_websocket_new(&(EmscriptenWebSocketCreateAttributes){
7+
.url = "ws://localhost:9000",
8+
.protocols = "text",
9+
});
10+
11+
assert(s > 0);
12+
13+
return 0;
14+
}

0 commit comments

Comments
 (0)