Address sbc100 review comments

Author: hoodmane

test/other/tty.c test/other/libtty.ctest/other/tty.c renamed to test/other/libtty.c

@@ -1,3 +1,4 @@
+#include <assert.h>
 #include <emscripten.h>
 #include <errno.h>
 #include <fcntl.h>
@@ -113,7 +114,7 @@ int main() {
 
   printf("\nTest 1: open custom TTY device and check isatty\n");
   int fd = open("/custom_tty", O_RDWR);
-  printf("open custom_tty: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   printf("isatty: %d\n", isatty(fd));
   printf("errno after open: %s\n", strerror(errno));
   errno = 0;
@@ -160,7 +161,7 @@ int main() {
 
   printf("\nTest 8: no put_char\n");
   fd = open("/tty_no_putchar", O_WRONLY);
-  printf("open: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   bytesWritten = write(fd, writeBuffer, strlen(writeBuffer));
   printf("write: %zd\n", bytesWritten);
   printf("errno: %s\n", strerror(errno));
@@ -169,7 +170,7 @@ int main() {
 
   printf("\nTest 9: no get_char\n");
   fd = open("/tty_no_getchar", O_RDONLY);
-  printf("open: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   bytesRead = read(fd, readBuffer, sizeof(readBuffer));
   printf("read: %zd\n", bytesRead);
   printf("errno: %s\n", strerror(errno));
@@ -178,7 +179,7 @@ int main() {
 
   printf("\nTest 10: put_char throws\n");
   fd = open("/tty_throw_putchar", O_WRONLY);
-  printf("open: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   bytesWritten = write(fd, writeBuffer, strlen(writeBuffer));
   printf("write: %zd\n", bytesWritten);
   printf("errno: %s\n", strerror(errno));
@@ -187,7 +188,7 @@ int main() {
 
   printf("\nTest 11: get_char throws\n");
   fd = open("/tty_throw_getchar", O_RDONLY);
-  printf("open: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   bytesRead = read(fd, readBuffer, sizeof(readBuffer));
   printf("read: %zd\n", bytesRead);
   printf("errno: %s\n", strerror(errno));
@@ -196,7 +197,7 @@ int main() {
 
   printf("\nTest 12: get_char returns undefined\n");
   fd = open("/tty_empty", O_RDONLY);
-  printf("open: %d\n", fd >= 0 ? 1 : 0);
+  assert(fd >= 0);
   bytesRead = read(fd, readBuffer, sizeof(readBuffer));
   printf("read: %zd\n", bytesRead);
   printf("errno: %s\n", strerror(errno));

test/other/tty.out test/other/libtty.outtest/other/tty.out renamed to test/other/libtty.out

@@ -1,6 +1,5 @@
 
 Test 1: open custom TTY device and check isatty
-open custom_tty: 1
 isatty: 1
 errno after open: Success
 
@@ -33,27 +32,22 @@ errno after fsync: Success
 fsync called
 
 Test 8: no put_char
-open: 1
 write: -1
 errno: No such device or address
 
 Test 9: no get_char
-open: 1
 read: -1
 errno: No such device or address
 
 Test 10: put_char throws
-open: 1
 write: -1
 errno: I/O error
 
 Test 11: get_char throws
-open: 1
 read: -1
 errno: I/O error
 
 Test 12: get_char returns undefined
-open: 1
 read: -1
 errno: Resource temporarily unavailable
 

test/test_other.py

@@ -13176,7 +13176,7 @@ def test_unistd_isatty(self):
     self.do_runf('unistd/isatty.c', 'success')
 
   def test_libtty(self):
-    self.do_other_test('tty.c')
+    self.do_other_test('libtty.c')
 
   def test_unistd_login(self):
     self.do_run_in_out_file_test('unistd/login.c')