Skip to content

Commit eff7318

Browse files
authored
Use consistent message (done) to signal test success. NFC (#26824)
We had some tests using `done` and others using `success`, and since `done` was more popular I decided to standardize on that. As a followup, I think we can perhaps make this the default for the `do_runf` method which will simplify things further.
1 parent 4e32560 commit eff7318

109 files changed

Lines changed: 206 additions & 238 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

test/browser/test_4gb.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ int main() {
3333
printf("wrote %d in JS, read %d from C\n", 2 * i, fromC);
3434
}
3535

36-
puts("success");
36+
puts("done");
3737
}
3838

test/browser/test_4gb.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,4 @@ wrote 58 in JS, read 58 from C
124124
test 30
125125
wrote 30 in C, read 30 from JS
126126
wrote 60 in JS, read 60 from C
127-
success
127+
done

test/browser/test_4gb_fail.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ int main() {
2626
// We should have allocated less than 4GB (we can't get to exactly 4GB
2727
// since we started with some small amount, and then add 512MB chunks).
2828
assert(num_allocations < 8);
29-
puts("success");
29+
puts("done");
3030
}

test/browser/test_4gb_fail.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
failed to allocate any more
2-
success
2+
done

test/browser/test_glfw_events.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,6 @@ int main() {
242242
printf("test failed\n");
243243
return 1;
244244
}
245-
printf("success\n");
245+
printf("done\n");
246246
return 0;
247247
}

test/core/pthread/test_pthread_dylink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ int main(int argc, char* argv[]) {
3333
pthread_create(&thread, NULL, thread_main, NULL);
3434
pthread_join(thread, NULL);
3535

36-
printf("success\n");
36+
printf("done\n");
3737
return 0;
3838
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
success
1+
done

test/core/pthread/test_pthread_dylink_tls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,5 +69,5 @@ int main() {
6969
assert(save_side == get_side_tls());
7070
assert(save_main == get_main_tls());
7171

72-
printf("success\n");
72+
printf("done\n");
7373
}

test/core/pthread/test_pthread_dylink_tls.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ side_tls direct : 52 43
2020
main_tls value : 20 11
2121
main_tls direct : 20 11
2222

23-
success
23+
done

test/core/test_autodebug.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ int main() {
1414
double d = printf("some numbers: %d %f\n", 42, 2.18281828);
1515
uint64_t j = printf("some more: %lld %lf\n", 1337ll, 3.14159);
1616
printf("counts: %lld %lf\n", j, d);
17-
puts("success");
17+
puts("done");
1818
return 0;
1919
}

0 commit comments

Comments
 (0)