Skip to content

Commit f2cd302

Browse files
authored
Fix regression in wasm64.test_pthread_join_and_asyncify (#26904)
This test was broken by #26879 Fixes: #26902
1 parent e6ebce4 commit f2cd302

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,7 @@ jobs:
10951095
core0.test_async_ccall_promise_jspi*
10961096
core0.test_cubescript_jspi
10971097
core0.test_poll_blocking_asyncify_jspi
1098+
wasm64.test_pthread_join_and_asyncify
10981099
"
10991100
- upload-test-results
11001101
test-other:

src/parseTools.mjs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,11 @@ Please update to new syntax.`);
753753

754754
if (needArgConversion) {
755755
if (needRtnConversion) {
756-
return `((${args}) => Number(${getWasmTableEntry}.call(null, ${callArgs})))`;
756+
if (promising) {
757+
return `((${args}) => ${getWasmTableEntry}.call(null, ${callArgs}).then(Number))`;
758+
} else {
759+
return `((${args}) => Number(${getWasmTableEntry}.call(null, ${callArgs})))`;
760+
}
757761
} else {
758762
return `((${args}) => ${getWasmTableEntry}.call(null, ${callArgs}))`;
759763
}

0 commit comments

Comments
 (0)