[syscall] Accept O_NONBLOCK flag in pipe2 (#26501)

Accept O_NONBLOCK and set it on the created pipe streams, it is a no-op in
practice, but there is no reason to not allow it.

Author: thiblahute

src/lib/libsyscall.js

@@ -199,12 +199,18 @@ var SyscallsLibrary = {
     if (fdPtr == 0) {
       throw new FS.ErrnoError({{{ cDefs.EFAULT }}});
     }
-    if (flags && flags != {{{ cDefs.O_CLOEXEC }}}) {
+    var validFlags = {{{ cDefs.O_CLOEXEC }}} | {{{ cDefs.O_NONBLOCK }}};
+    if (flags & ~validFlags) {
       throw new FS.ErrnoError({{{ cDefs.ENOTSUP }}});
     }
 
     var res = PIPEFS.createPipe();
 
+    if (flags & {{{ cDefs.O_NONBLOCK }}}) {
+      FS.getStream(res.readable_fd).flags |= {{{ cDefs.O_NONBLOCK }}};
+      FS.getStream(res.writable_fd).flags |= {{{ cDefs.O_NONBLOCK }}};
+    }
+
     {{{ makeSetValue('fdPtr', 0, 'res.readable_fd', 'i32') }}};
     {{{ makeSetValue('fdPtr', 4, 'res.writable_fd', 'i32') }}};
 

test/codesize/test_codesize_hello_dylink_all.json

@@ -1,7 +1,7 @@
 {
-  "a.out.js": 244300,
+  "a.out.js": 244343,
   "a.out.nodebug.wasm": 577444,
-  "total": 821744,
+  "total": 821787,
   "sent": [
     "IMG_Init",
     "IMG_Load",

test/unistd/misc.c

@@ -86,6 +86,14 @@ int main() {
   printf("pipe2(bad): %d", pipe2(0, 0));
   printf(", errno: %d\n", errno);
   errno = 0;
+  printf("pipe2(O_NONBLOCK): %d", pipe2(pipe_arg, O_NONBLOCK));
+  printf(", errno: %d\n", errno);
+  printf("pipe2(O_NONBLOCK) read flags: %d\n", (fcntl(pipe_arg[0], F_GETFL) & O_NONBLOCK) != 0);
+  printf("pipe2(O_NONBLOCK) write flags: %d\n", (fcntl(pipe_arg[1], F_GETFL) & O_NONBLOCK) != 0);
+  errno = 0;
+  printf("pipe2(O_CLOEXEC|O_NONBLOCK): %d", pipe2(pipe_arg, O_CLOEXEC | O_NONBLOCK));
+  printf(", errno: %d\n", errno);
+  errno = 0;
 
   char* exec_argv[] = {"arg", 0};
   char* exec_env[] = {"a=b", 0};

test/unistd/misc.out

@@ -15,6 +15,10 @@ pipe(good): 0, errno: 0
 pipe(bad): -1, errno: 21
 pipe2(good): 0, errno: 0
 pipe2(bad): -1, errno: 21
+pipe2(O_NONBLOCK): 0, errno: 0
+pipe2(O_NONBLOCK) read flags: 1
+pipe2(O_NONBLOCK) write flags: 1
+pipe2(O_CLOEXEC|O_NONBLOCK): 0, errno: 0
 execl: -1, errno: 45
 execle: -1, errno: 45
 execlp: -1, errno: 45