[ports] SDL3_mixer 3.2.0#26571
Conversation
|
SDL3 update was moved to another PR |
Thanks! |
|
tests were added: |
SDL3 update is needed for SDL3_mixer port See #26571
test/browser/test_sdl3_mixer.c
Outdated
|
|
||
| emscripten_set_main_loop(sound_loop_then_quit, 0, 1); | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
We use 2-space indentation. Maybe run this through clang-format? Or is this file designed to mirror an existing one?
There was a problem hiding this comment.
sure, fixed. I've copied the style from another c file.
btw there are lots of c files with 4 spaces and tab indents..
| if formats != '': | ||
| libname += '-' + formats | ||
| if settings.PTHREADS: | ||
| libname += '-mt' |
There was a problem hiding this comment.
Does this library actually use threading (or atomics)?
There was a problem hiding this comment.
I've copied this part from sdl2_mixer.py
not sure.
there are no -pthreads flag check in cmakelists.txt.
only set(WAVPACK_ENABLE_THREADS FALSE) for wavpack which is not supported.
Should we remove this option?
There was a problem hiding this comment.
I think maybe because SDL3 itself has a threaded variant its required that all the sub-libraries do it.. but I can't remember the exact rationale.
Maybe leave it as is.
2 participants
Simple port of SDL3_mixer with only WAV format available.
Test added.