Bump minimum supported node version v12.22.9 to v18.3.0#26604
Bump minimum supported node version v12.22.9 to v18.3.0#26604sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
update_min_node
branch
2 times, most recently
from
414dff4 to
dac21e5
Compare
|
Key Node.js LTS Status (As of early 2026):
|
sbc100
changed the title
sbc100
force-pushed
the
update_min_node
branch
3 times, most recently
from
0b3b234 to
5e9e27f
Compare
sbc100
changed the title
This change updates the minimum support node version for the generated code. v18.3.0 was chosen because that is currently minimum supported version for running emscripten itself.
It's past April 2025. Does that mean Node 18 is no longer supported even in maintenance? |
Yes, I believe so |
| 'presets': ['@babel/preset-env'], | ||
| 'plugins': [], | ||
| 'targets': {}, | ||
| 'parserOpts': { |
There was a problem hiding this comment.
This whole dict entry can now be removed, as it was only used by the strip-node-prefix.mjs Babel plugin (see e.g. commit 5dafa6b where it was introduced).
There was a problem hiding this comment.
It might be better to just remove this test entirely.
| Minimum supported value is 122209, which was released 2022-01-11 (see | ||
| feature_matrix.py). This version aligns with the Ubuntu TLS 22.04 (Jammy). | ||
| Minimum supported value is 180300, which was released 2022-05-18 (see | ||
| feature_matrix.py). |
There was a problem hiding this comment.
Is Ubuntu TLS 22.04 no longer supported out of the box after this change? (Is there value in keeping track of which Ubuntu version is min. supported out of the box?)
There was a problem hiding this comment.
If one is targeting nodejs, and one wants to run the resulting program with the default nodejs that ships with Ubuntu TLS 22.04 (Jammy), then yes that is no longer supported.
However, note that emcc itself already dropping support for running the compiler using node v12 a long time back.
| # FF:79 CHROME:85 SAFARI:14 | ||
| # Taking the highest requirements gives is our minimum: | ||
| # Max Version: FF:79 CHROME:85 SAFARI:14 NODE:16 | ||
| # Max Version: FF:79 CHROME:85 SAFARI:14 |
There was a problem hiding this comment.
I'm not sure if it is a good idea to remove information from comments like this? Because if someone reads this later, they can think "oh this does not address Node min version, what about Node?", and then have to go and re-figure that out to confirm that the version of Node won't be a problem.
Maybe have NODE:14 (unsupported) or similar?
There was a problem hiding this comment.
Ok will revert this part.
4 participants
Bump minimum supported node version v12.22.9 to v18.3.0.
This change updates the minimum support node version for the generated
code.
v18.3.0 was chosen because that is currently minimum supported version
for running emscripten itself.