Skip to content

Fix multiple jscompiler errors #26632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 8 commits into from
Apr 9, 2026
Merged

Fix multiple jscompiler errors #26632

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
26d3f92
Fix multiple jscompiler errors
stephenduong1004 Apr 6, 2026
083654b
Delete return {void} doc
stephenduong1004 Apr 6, 2026
a8e48ee
revert changes to preamble.js
stephenduong1004 Apr 7, 2026
c520169
Merge branch 'main' into patch-7
stephenduong1004 Apr 9, 2026
8ad6aca
Update test_codesize_file_preload.expected.js
stephenduong1004 Apr 9, 2026
093262e
Update test_codesize_minimal_O0.expected.js
stephenduong1004 Apr 9, 2026
eb1a0e5
Update test_unoptimized_code_size.json
stephenduong1004 Apr 9, 2026
04f94aa
Merge branch 'main' into patch-7
stephenduong1004 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/libembind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ var LibraryEmbind = {
}
#if ASSERTIONS
else if (typeof value != "bigint") {
throw new TypeError(`Cannot convert "${embindRepr(value)}" to ${this.name}`);
throw new TypeError(`Cannot convert "${embindRepr(value)}" to ${name}`);
}
assertIntegerRange(name, value, minRange, maxRange);
#endif
Expand Down Expand Up @@ -404,7 +404,7 @@ var LibraryEmbind = {
toWireType: (destructors, value) => {
#if ASSERTIONS
if (typeof value != "number" && typeof value != "boolean") {
throw new TypeError(`Cannot convert ${embindRepr(value)} to ${this.name}`);
throw new TypeError(`Cannot convert ${embindRepr(value)} to ${name}`);
}
#endif
// The VM will perform JS to Wasm value conversion, according to the spec:
Expand Down
1 change: 0 additions & 1 deletion src/lib/libwasi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ var WasiLibrary = {
#endif

proc_exit__nothrow: true,
proc_exit__docs: '/** @noreturn */',
proc_exit: (code) => {
#if MINIMAL_RUNTIME
throw `exit(${code})`;
Expand Down
10 changes: 5 additions & 5 deletions src/preamble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ function postRun() {

/**
* @param {string|number=} what
* @noreturn
*/
function abort(what) {
#if expectToReceiveOnModule('onAbort')
Expand Down Expand Up @@ -302,17 +301,18 @@ function abort(what) {
#if ASSERTIONS && !('$FS' in addedLibraryItems)
// show errors on likely calls to FS when it was not included
var FS = {
/** @return {*} */
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does @return {undefined} work here?

Copy link
Copy Markdown
Collaborator

@walkingeyerobot walkingeyerobot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return {void} may be the answer

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is now reverted.

error() {
abort('Filesystem support (FS) was not included. The problem is that you are using files from JS, but files were not used from C/C++, so filesystem support was not auto-included. You can force-include filesystem support with -sFORCE_FILESYSTEM');
},
init() { FS.error() },
createDataFile() { FS.error() },
createPreloadedFile() { FS.error() },
createLazyFile() { FS.error() },
open() { FS.error() },
mkdev() { FS.error() },
createLazyFile() { return (/** @type {?} */ (FS.error())); },
open() { return (/** @type {?} */ (FS.error())); },
mkdev() { return (/** @type {?} */ (FS.error())); },
Comment thread
stephenduong1004 marked this conversation as resolved.
Outdated
registerDevice() { FS.error() },
analyzePath() { FS.error() },
analyzePath() { return (/** @type {?} */ (FS.error())); },

ErrnoError() { FS.error() },
};
Expand Down
Loading