From 165ae0de832854220efd839357082044b25df827 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Wed, 8 Apr 2026 14:06:35 -0700 Subject: [PATCH] Remove redundant min version checks We dropped support for firefox older than 58 a long time back. We dropped support node older than 18.1 in #26604. --- tools/minimal_runtime_shell.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/minimal_runtime_shell.py b/tools/minimal_runtime_shell.py index c7f50fb1450b1..2b5a77d4b0786 100644 --- a/tools/minimal_runtime_shell.py +++ b/tools/minimal_runtime_shell.py @@ -26,7 +26,7 @@ def generate_minimal_runtime_load_statement(target_basename): # Expand {{{ DOWNLOAD_WASM }}} block from here (if we added #define support, this could be done in # the template directly) if settings.MINIMAL_RUNTIME_STREAMING_WASM_COMPILATION: - if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58: + if settings.MIN_SAFARI_VERSION < 150000: # https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/compileStreaming download_wasm = f"WebAssembly.compileStreaming ? WebAssembly.compileStreaming(fetch('{target_basename}.wasm')) : binary('{target_basename}.wasm')" else: @@ -35,7 +35,7 @@ def generate_minimal_runtime_load_statement(target_basename): elif settings.MINIMAL_RUNTIME_STREAMING_WASM_INSTANTIATION: # Same compatibility story as above for # https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming - if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58: + if settings.MIN_SAFARI_VERSION < 150000: download_wasm = f"!WebAssembly.instantiateStreaming && binary('{target_basename}.wasm')" else: # WebAssembly.instantiateStreaming() is unconditionally supported, so we do not download wasm