Skip to content

Remove redundant min version checks #26654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 8, 2026
+2 −2
Merged

Remove redundant min version checks #26654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/minimal_runtime_shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def generate_minimal_runtime_load_statement(target_basename):
# Expand {{{ DOWNLOAD_WASM }}} block from here (if we added #define support, this could be done in
# the template directly)
if settings.MINIMAL_RUNTIME_STREAMING_WASM_COMPILATION:
if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58:
if settings.MIN_SAFARI_VERSION < 150000:
# https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/compileStreaming
download_wasm = f"WebAssembly.compileStreaming ? WebAssembly.compileStreaming(fetch('{target_basename}.wasm')) : binary('{target_basename}.wasm')"
else:
Expand All @@ -35,7 +35,7 @@ def generate_minimal_runtime_load_statement(target_basename):
elif settings.MINIMAL_RUNTIME_STREAMING_WASM_INSTANTIATION:
# Same compatibility story as above for
# https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming
if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58:
if settings.MIN_SAFARI_VERSION < 150000:
download_wasm = f"!WebAssembly.instantiateStreaming && binary('{target_basename}.wasm')"
else:
# WebAssembly.instantiateStreaming() is unconditionally supported, so we do not download wasm
Expand Down
Loading