Fix emscripten_is_main_runtime_thread() under in audio worklet#26818
Merged
juj merged 1 commit intoemscripten-core:mainfrom Apr 30, 2026
Merged
Fix emscripten_is_main_runtime_thread() under in audio worklet#26818juj merged 1 commit intoemscripten-core:mainfrom
juj merged 1 commit intoemscripten-core:mainfrom
Conversation
This function was incorrectly returning `true` in audio worklets because `ENVIRONMENT_IS_WORKER` is not defined in audio worklets.
juj
approved these changes
Apr 30, 2026
Collaborator
|
Given that Audio Worklets are involved in #26823, I'll land this to test if this has an effect there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was incorrectly returning
truein audio worklets becauseENVIRONMENT_IS_WORKERis not defined in audio worklets.