Demote the warning of Closure falling back to Java from warning to a debug line#26820
Merged
juj merged 1 commit intoemscripten-core:mainfrom Apr 30, 2026
Merged
Conversation
…debug line. If Java works, this is not a problem, and if Java does not work, it will make itself known. Fixes other.test_closure_warnings* on Apple Silicon Mac devices.
Collaborator
|
We really should get around to landing #24679. IIRC it had a small code size regression what was blocking it :( |
sbc100
approved these changes
Apr 30, 2026
Collaborator
Author
|
Does newer Closure change which arch+OSes get native JavaScript versions of Closure? |
Collaborator
My understanding is that the new version ships a arm64 version for macOS, so that warning will move from the majority of users (arm64 macOS) to the minority (x64 macOS). My understanding is that we are quite close to dropping support for x64 macOS: emscripten-core/emsdk#1548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demote the warning of Closure falling back to Java from warning to a debug line. If Java works, this is not a problem, and if Java does not work, it will make itself known. Fixes other.test_closure_warnings* on Apple Silicon Mac devices.
http://clbri.com:8010/api/v2/logs/406742/raw_inline