Fix emrun.test_emrun_info on Apple Silicon macOS#26821
Merged
juj merged 1 commit intoemscripten-core:mainfrom Apr 30, 2026
Merged
Fix emrun.test_emrun_info on Apple Silicon macOS#26821juj merged 1 commit intoemscripten-core:mainfrom
juj merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
approved these changes
Apr 30, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I'm wondering, do you ever actually use this features?
I've never once used in 10 years, or heard of anyone using it?
Can/should we just remove it?
lgtm either way.
Collaborator
Author
This is currently not really used, but I did develop this feature, when it was used as part of a CI system performance test harness at Mozilla. There each agent would do a HTTP query to get this info, and then store that info as part of the CI records on the perf results. If I were to set up a perf harness, I would still do it the same way as here to accumulate the test device data to perf result databases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.