Remove unused field from pthread struct. NFC#26900
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom May 10, 2026
Merged
Remove unused field from pthread struct. NFC#26900sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100 merged 2 commits intoemscripten-core:mainfrom
Conversation
Split out from emscripten-core#26857.
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (7) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_ctors1.json: 151887 => 151887 [+0 bytes / +0.00%] codesize/test_codesize_cxx_except_wasm.json: 167018 => 167018 [+0 bytes / +0.00%] codesize/test_codesize_cxx_except_wasm_legacy.json: 164898 => 164898 [+0 bytes / +0.00%] codesize/test_codesize_cxx_noexcept.json: 153917 => 153917 [+0 bytes / +0.00%] codesize/test_codesize_hello_dylink.json: 43922 => 43922 [+0 bytes / +0.00%] codesize/test_codesize_minimal_pthreads.json: 26419 => 26419 [+0 bytes / +0.00%] codesize/test_codesize_minimal_pthreads_memgrowth.json: 26829 => 26829 [+0 bytes / +0.00%] Average change: +0.00% (+0.00% - +0.00%) ```
sbc100
reviewed
May 9, 2026
| "p_proto": 8 | ||
| }, | ||
| "pthread": { | ||
| "__size__": 124, |
Collaborator
There was a problem hiding this comment.
Did src/struct_info_generated_wasm64.json not change? Maybe something to do with alignment?
Collaborator
Author
There was a problem hiding this comment.
Indeed, I tried ./emcc --clear-cache && ./tools/gen_struct_info.py --wasm64 but nothing changed.
Collaborator
There was a problem hiding this comment.
Yeah, must be that due to alignment that the overall size doesn't change.
Collaborator
Author
Sorry, I missed that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #26857.