Skip to content

Remove unused field from pthread struct. NFC #26900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 2 commits into from
May 10, 2026
Merged

Remove unused field from pthread struct. NFC #26900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957272f
Remove unused field from pthread struct. NFC
kleisauke May 7, 2026
98c0d10
Automatic rebaseline of codesize expectations. NFC
kleisauke May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/struct_info_generated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,11 +1040,11 @@
"p_proto": 8
},
"pthread": {
"__size__": 124,
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did src/struct_info_generated_wasm64.json not change? Maybe something to do with alignment?

Copy link
Copy Markdown
Collaborator Author

@kleisauke kleisauke May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I tried ./emcc --clear-cache && ./tools/gen_struct_info.py --wasm64 but nothing changed.

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, must be that due to alignment that the overall size doesn't change.

"profilerBlock": 100,
"__size__": 120,
"profilerBlock": 96,
"stack": 48,
"stack_size": 52,
"waiting_async": 116
"waiting_async": 112
},
"pthread_attr_t": {
"__size__": 44,
Expand Down
3 changes: 2 additions & 1 deletion system/lib/libc/musl/src/internal/pthread_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ struct pthread {
#ifndef __EMSCRIPTEN__
// Emscripten uses C11 _Thread_local instead for locale
locale_t locale;
#endif
// Emscripten doesn't use this field.
volatile int killlock[1];
#endif
char *dlerror_buf;
void *stdio_locks;

Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_cxx_ctors1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 19260,
"a.out.js.gz": 7991,
"a.out.nodebug.wasm": 132627,
"a.out.nodebug.wasm.gz": 49919,
"a.out.nodebug.wasm.gz": 49918,
"total": 151887,
"total_gz": 57910,
"total_gz": 57909,
"sent": [
"__cxa_throw",
"_abort_js",
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_cxx_except_wasm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 19092,
"a.out.js.gz": 7925,
"a.out.nodebug.wasm": 147926,
"a.out.nodebug.wasm.gz": 55308,
"a.out.nodebug.wasm.gz": 55309,
"total": 167018,
"total_gz": 63233,
"total_gz": 63234,
"sent": [
"_abort_js",
"_tzset_js",
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_cxx_except_wasm_legacy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 19166,
"a.out.js.gz": 7949,
"a.out.nodebug.wasm": 145732,
"a.out.nodebug.wasm.gz": 54936,
"a.out.nodebug.wasm.gz": 54935,
"total": 164898,
"total_gz": 62885,
"total_gz": 62884,
"sent": [
"_abort_js",
"_tzset_js",
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_cxx_noexcept.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 19260,
"a.out.js.gz": 7991,
"a.out.nodebug.wasm": 134657,
"a.out.nodebug.wasm.gz": 50774,
"a.out.nodebug.wasm.gz": 50773,
"total": 153917,
"total_gz": 58765,
"total_gz": 58764,
"sent": [
"__cxa_throw",
"_abort_js",
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_hello_dylink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 26251,
"a.out.js.gz": 11195,
"a.out.nodebug.wasm": 17671,
"a.out.nodebug.wasm.gz": 8920,
"a.out.nodebug.wasm.gz": 8921,
"total": 43922,
"total_gz": 20115,
"total_gz": 20116,
"sent": [
"__syscall_stat64",
"emscripten_resize_heap",
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_minimal_pthreads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"a.out.js": 7372,
"a.out.js.gz": 3594,
"a.out.js.gz": 3593,
"a.out.nodebug.wasm": 19047,
"a.out.nodebug.wasm.gz": 8795,
"a.out.nodebug.wasm.gz": 8796,
"total": 26419,
"total_gz": 12389,
"sent": [
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_minimal_pthreads_memgrowth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"a.out.js": 7781,
"a.out.js.gz": 3797,
"a.out.nodebug.wasm": 19048,
"a.out.nodebug.wasm.gz": 8796,
"a.out.nodebug.wasm.gz": 8797,
"total": 26829,
"total_gz": 12593,
"total_gz": 12594,
"sent": [
"a (memory)",
"b (exit)",
Expand Down
Loading