Skip to content

Fix regression in wasm64.test_pthread_join_and_asyncify #26904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 9, 2026
+6 −1
Merged

Fix regression in wasm64.test_pthread_join_and_asyncify #26904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,7 @@ jobs:
core0.test_async_ccall_promise_jspi*
core0.test_cubescript_jspi
core0.test_poll_blocking_asyncify_jspi
wasm64.test_pthread_join_and_asyncify
"
- upload-test-results
test-other:
Expand Down
6 changes: 5 additions & 1 deletion src/parseTools.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,11 @@ Please update to new syntax.`);

if (needArgConversion) {
if (needRtnConversion) {
return `((${args}) => Number(${getWasmTableEntry}.call(null, ${callArgs})))`;
if (promising) {
return `((${args}) => ${getWasmTableEntry}.call(null, ${callArgs}).then(Number))`;
} else {
return `((${args}) => Number(${getWasmTableEntry}.call(null, ${callArgs})))`;
}
} else {
return `((${args}) => ${getWasmTableEntry}.call(null, ${callArgs}))`;
}
Expand Down
Loading