-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow emscripten_atomic_wait_suspending to return synchronously when possible
#26947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sbc100
merged 1 commit into
emscripten-core:main
from
sbc100:emscripten_atomic_wait_suspending2
May 15, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright 2026 The Emscripten Authors. All rights reserved. | ||
| * Emscripten is available under two separate licenses, the MIT license and the | ||
| * University of Illinois/NCSA Open Source License. Both these licenses can be | ||
| * found in the LICENSE file. | ||
| */ | ||
|
|
||
| #include <emscripten/promise.h> | ||
| #include <emscripten/atomic.h> | ||
| #include "threading_internal.h" | ||
|
|
||
| ATOMICS_WAIT_TOKEN_T emscripten_atomic_wait_suspending(volatile void * _Nonnull addr, | ||
| uint32_t value, | ||
| double maxWaitMilliseconds) { | ||
| intptr_t res = _emscripten_atomic_wait_promise(addr, value, maxWaitMilliseconds); | ||
| // A negative value is a synchronous result code. | ||
| if (res < 0) { | ||
| return (ATOMICS_WAIT_TOKEN_T)-res; | ||
| } | ||
| // Otherwise a positive value is a promise ID, and we can then `await` using | ||
| // ASYNCIFY/JSPI. | ||
| em_promise_t promise = (em_promise_t)res; | ||
| void* await_result = emscripten_promise_await_unchecked(promise); | ||
| return (ATOMICS_WAIT_TOKEN_T)(intptr_t)await_result; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty in the weeds. These to phases of
gen_sig_info.pyrun withuse_cxx=True, which doesn't (can't) include musl C internal headers (which don't work in C++ mode).However, since
SHARED_MEMORYdefaults to enabled ingen_sig_infowe inclduelibatomic.jsin the build and end up with this error without this change:Its kind of hard to explain, but the only output of this script is the
libsig.jsand if that has not changed we can be sure we didn't break the script. i.e. there are no other / subtle breakage that can occur from changinggen_sig_info.py