Allow null/undefined handler in emscripten_promise_then#26951
Merged
Conversation
sbc100
force-pushed
the
promise_then_null_handlers
branch
2 times, most recently
from
47e6d28 to
160b473
Compare
tlively
approved these changes
May 14, 2026
Just like in the JS `promise.then` API it is now valid to pass NULL (0) callbacks to emscripten_promise_then.
sbc100
force-pushed
the
promise_then_null_handlers
branch
from
160b473 to
cbaee1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like in the JS
promise.thenAPI it is now valid to pass NULL (0) callbacks to emscripten_promise_then.