Use cmdline.options consistently. NFC - #27439
Merged
Merged
Conversation
sbc100
force-pushed
the
cmdline_options
branch
2 times, most recently
from
July 29, 2026 00:29
188ad4e to
e30afe8
Compare
Collaborator
Author
|
Hopefully this will make changes like this more obviously correct: #27422 |
sbc100
enabled auto-merge (squash)
July 29, 2026 00:47
kripken
approved these changes
Jul 29, 2026
We had some parts of the codebase that were using the ambient/global `cmdline.options` and other that were passing the options object around as as a param. For a tool like a compiler it think use the global options options object if pretty reasonable and keeps the code simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some parts of the codebase that were using the ambient/global
cmdline.optionsand other that were passing the options object around as as a param.For a tool like a compiler it think use the global options options object if pretty reasonable and keeps the code simple.