Skip to content

Commit 9d03d64

Browse files
authored
Fix test_binaryen_from_source on windows. NFC (#1660)
This fixes the build, but I left it disabled because it takes over 30 minutes to build. Fixes: #1624
1 parent a2dc067 commit 9d03d64

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.circleci/config.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,10 @@ jobs:
139139
- checkout
140140
- run: where python
141141
- run: pip install pip-system-certs
142+
- run:
143+
name: Install packages
144+
command: choco install -y cmake.portable ninja pkgconfiglite
145+
142146
- run:
143147
name: Install latest
144148
shell: cmd.exe

test/test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,9 @@ def test_specific_version_full(self):
275275

276276
def test_binaryen_from_source(self):
277277
if WINDOWS:
278-
self.skipTest("https://github.com/emscripten-core/emsdk/issues/1624")
279-
print('test binaryen source build')
280-
run_emsdk(['install', '--build=Release', '--generator=Unix Makefiles', 'binaryen-main-64bit'])
278+
# It takes over 30 mins to build binaryen using Visual Studio in CI
279+
self.skipTest('test is too slow under windows')
280+
run_emsdk(['install', '--build=Release', 'binaryen-main-64bit'])
281281

282282
def test_no_32bit(self):
283283
print('test 32-bit error')

0 commit comments

Comments
 (0)