Fixes for premature exit from decoding#3
Open
pieper wants to merge 1 commit into
Open
Conversation
Need to read sample file with this code: https://github.com/covictory/pngdump
Member
|
Thanks @pieper , should these be submitted upstream perhaps? (they don't seem specific to emscripten at first glance) |
Author
|
Hi - good question - I didn't try but could investigate. I noticed a note that something similar had been done in other parts of the libpng code. Maybe this is just in the way error handling happens in emscripten leads to an abort instead of just a message. I'm rebuilding now with this project's build script and can see what happens for different libpng versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to change errors to warnings to read sample file with this code:
https://github.com/covictory/pngdump
https://github.com/covictory/pngdump/blob/master/testsite/cxr16bit.png