chore!: harden 7.x release readiness checks

Expand release checks for hooks, favicon settings, and Starterkit output.

Verify generated child themes and upload smoke artifacts on failure.

Refresh template parity language for the parent-theme removal.

Author: Callin Mullaney

.github/scripts/generate-template-map.sh

@@ -67,7 +67,7 @@ reason_for_template() {
   fi
 
   if [ "$modified" = "No" ]; then
-    echo "Parent parity"
+    echo "Core baseline parity"
     return
   fi
 

.github/scripts/release-check.cjs

@@ -3,21 +3,69 @@
 set -euo pipefail
 
 # Generates a child theme from the Whisk starter source and proves the result is
-# installable. This is intentionally a Drupal Starterkit smoke test, not a
-# frontend build test; it guards the PHP/theme metadata contract that release
-# consumers hit before Node tooling runs.
+# installable, renderable, and compatible with the Vite-based build workflow
+# powered by Emulsify Core 4.
 if [ "$#" -lt 2 ]; then
   echo "Usage: $0 <fixture-dir> <output-dir>" >&2
   exit 1
 fi
 
 fixture_dir="$1"
 output_dir="$2"
-generated_theme="emulsify_fixture"
+generated_theme="${EMULSIFY_STARTERKIT_THEME:-emulsify_fixture}"
 generated_theme_dir="${fixture_dir}/web/themes/custom/${generated_theme}"
+generated_theme_info="${generated_theme_dir}/${generated_theme}.info.yml"
 script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+artifact_info="${output_dir}/generated-theme-info.yml"
+npm_install_log="${output_dir}/npm-install.log"
+npm_build_log="${output_dir}/npm-build.log"
+storybook_build_log="${output_dir}/storybook-build.log"
 
 mkdir -p "$output_dir"
+printf 'npm install has not run yet.\n' >"$npm_install_log"
+printf 'npm run build has not run yet.\n' >"$npm_build_log"
+printf 'npm run storybook-build has not run.\n' >"$storybook_build_log"
+
+fail() {
+  echo "$1" >&2
+  exit 1
+}
+
+show_log_tail() {
+  local log_file="$1"
+
+  if [ -f "$log_file" ]; then
+    echo "--- ${log_file} tail ---" >&2
+    tail -n 160 "$log_file" >&2 || true
+  fi
+}
+
+run_logged() {
+  local log_file="$1"
+  shift
+
+  if ! "$@" >"$log_file" 2>&1; then
+    echo "Command failed: $*" >&2
+    show_log_tail "$log_file"
+    exit 1
+  fi
+}
+
+assert_missing_file() {
+  local relative_path="$1"
+
+  if [ -e "${generated_theme_dir}/${relative_path}" ]; then
+    fail "Starterkit output should not include ${relative_path}."
+  fi
+}
+
+assert_missing_glob() {
+  local glob_pattern="$1"
+
+  if compgen -G "${generated_theme_dir}/${glob_pattern}" >/dev/null; then
+    fail "Starterkit output should not include files matching ${glob_pattern}."
+  fi
+}
 
 (
   cd "$fixture_dir"
@@ -26,21 +74,27 @@ mkdir -p "$output_dir"
   php web/core/scripts/drupal generate-theme "$generated_theme" --starterkit whisk --path themes/custom -n
 )
 
-test -f "${generated_theme_dir}/${generated_theme}.info.yml"
-grep -Eq "^('?base theme'?): emulsify$" "${generated_theme_dir}/${generated_theme}.info.yml"
+test -f "$generated_theme_info"
+cp "$generated_theme_info" "$artifact_info"
 
-# Generated themes must be visible/installable and should not carry the source
-# theme's private project config marker into consumer projects.
-if grep -q '^hidden: true$' "${generated_theme_dir}/${generated_theme}.info.yml"; then
-  echo "Generated theme should not remain hidden." >&2
-  exit 1
+if ! grep -Eq "^('?base theme'?): emulsify$" "$generated_theme_info"; then
+  fail "Generated theme must use emulsify as its runtime parent theme."
 fi
 
-if [ -e "${generated_theme_dir}/project.emulsify.json" ]; then
-  echo "Starterkit output should not include project.emulsify.json." >&2
-  exit 1
+# Generated themes must be visible/installable and should not carry the source
+# theme's private starter metadata into consumer projects.
+if grep -Eq '^hidden:[[:space:]]*true[[:space:]]*$' "$generated_theme_info"; then
+  fail "Generated theme should not remain hidden."
 fi
 
+assert_missing_file "project.emulsify.json"
+assert_missing_file "whisk.starterkit.yml"
+assert_missing_file "whisk.info.emulsify.yml"
+assert_missing_file "${generated_theme}.starterkit.yml"
+assert_missing_file "${generated_theme}.info.emulsify.yml"
+assert_missing_glob "*.starterkit.yml"
+assert_missing_glob "*.info.emulsify.yml"
+
 (
   cd "$fixture_dir"
   ./vendor/bin/drush theme:enable "$generated_theme" -y
@@ -49,6 +103,21 @@ fi
 )
 
 # Finish by rendering representative pages through the generated theme. This
-# catches missing libraries, broken base-theme inheritance, and template issues
+# catches missing libraries, broken parent-theme inheritance, and template issues
 # that pure file assertions cannot see.
 bash "${script_dir}/render-reference-pages.sh" "$fixture_dir" "$output_dir"
+
+(
+  cd "$generated_theme_dir"
+  install_args=(install --no-audit --no-fund)
+  if [ -f package-lock.json ]; then
+    install_args=(ci --no-audit --no-fund)
+  fi
+
+  run_logged "$npm_install_log" npm "${install_args[@]}"
+  run_logged "$npm_build_log" npm run build
+
+  if [ "${EMULSIFY_STARTERKIT_STORYBOOK_BUILD:-0}" = "1" ]; then
+    run_logged "$storybook_build_log" npm run storybook-build
+  fi
+)

.github/scripts/starterkit-smoke.sh

@@ -3,7 +3,7 @@
 set -euo pipefail
 
 # Verifies Emulsify owns the same template path surface that stable9 provides
-# without inheriting stable9 as a base theme. This is a path-contract check:
+# without inheriting stable9 as a parent theme. This is a path-contract check:
 # templates may intentionally differ in content, but missing stable9 paths would
 # reintroduce hidden fallback behavior in Drupal 11/12 readiness testing.
 if [ "$#" -lt 2 ]; then
@@ -39,7 +39,7 @@ if [ ! -d "$repo_templates_dir" ]; then
 fi
 
 if grep -Eq "^base theme: stable9$" "${repo_root}/emulsify.info.yml"; then
-  echo "emulsify.info.yml should not declare stable9 as a base theme." >&2
+  echo "emulsify.info.yml should not declare stable9 as its parent theme." >&2
   exit 1
 fi
 

.github/scripts/template-parity.sh

@@ -45,6 +45,10 @@ jobs:
           tools: composer:v2
           extensions: gd, imagick
 
+      - { name: Setup Node, uses: actions/setup-node@v4, with: { node-version: 24 } }
+
+      - { name: Run static release check, run: 'npm run release:check -- --skip-smoke' }
+
       - name: Build fixture site
         id: build_fixture
         continue-on-error: ${{ matrix.experimental }}
@@ -64,7 +68,7 @@ jobs:
           name: stable9-template-parity-${{ matrix.artifact-suffix }}
           path: ${{ runner.temp }}/emulsify-template-parity.md
 
-      - name: Smoke test base theme page rendering
+      - name: Smoke test parent theme page rendering
         if: ${{ !cancelled() && steps.build_fixture.outcome == 'success' }}
         continue-on-error: ${{ matrix.experimental }}
         run: bash .github/scripts/render-reference-pages.sh /tmp/emulsify-fixture /tmp/emulsify-base-theme
@@ -79,7 +83,6 @@ jobs:
         continue-on-error: ${{ matrix.experimental }}
         run: bash .github/scripts/favicon-portability-smoke.sh /tmp/emulsify-fixture emulsify
 
-      - name: Generate and enable a Whisk-derived theme
-        if: ${{ !cancelled() && steps.build_fixture.outcome == 'success' }}
-        continue-on-error: ${{ matrix.experimental }}
-        run: bash .github/scripts/starterkit-smoke.sh /tmp/emulsify-fixture /tmp/emulsify-generated-theme
+      - { name: Generate and enable a Whisk-derived theme, id: starterkit_smoke, if: "${{ !cancelled() && steps.build_fixture.outcome == 'success' }}", continue-on-error: "${{ matrix.experimental }}", run: 'bash .github/scripts/starterkit-smoke.sh /tmp/emulsify-fixture "${{ runner.temp }}/emulsify-generated-theme"' }
+
+      - { name: Upload generated theme smoke artifacts, if: "${{ !cancelled() && steps.build_fixture.outcome == 'success' && steps.starterkit_smoke.outcome == 'failure' }}", uses: actions/upload-artifact@v4, with: { name: "generated-theme-smoke-${{ matrix.artifact-suffix }}", if-no-files-found: warn, path: "${{ runner.temp }}/emulsify-generated-theme" } }