EMULSIF-305: Add header component#175
Open
josue2591 wants to merge 8 commits into
Open
Conversation
❌ Deploy Preview for emulsify-ui-kit failed.
|
robherba
added
🚧 Work in Progress
…ulsif-305--header-component
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ulsif-305--header-component
… search input text color
…ayout responsiveness
robherba
added
👍 Ready for Review
robherba
changed the title
mariannuar
requested changes
May 23, 2026
mariannuar
left a comment
mariannuar
left a comment
Collaborator
There was a problem hiding this comment.
@robherba Most of the header looks good, but the main nav should reflect the design we already have implemented
Comment on lines
+39
to
+63
| {# Main navigation #} | ||
| <nav {{ bem('menu', [], header__base_class) }}> | ||
| <div {{ bem('search', ['mobile'], header__base_class) }}></div> | ||
| {% block header__menu %} | ||
| <ul> | ||
| {% for item in header__menu %} | ||
| <li {{ bem('menu-item', [], header__base_class) }}> | ||
| <a {{ bem('link', [], header__base_class ~ '__menu-item') }} href="{{ item.url }}"> | ||
| {{ item.label }} | ||
| </a> | ||
| {% if item.submenu %} | ||
| <button type="button" {{ bem('toggle', [], header__base_class ~ '__menu-item') }} aria-expanded="false" aria-controls=""> | ||
| {% include "@components/icons/_icon.twig" with { | ||
| icon__decorative: true, | ||
| icon__name: 'chevron-down', | ||
| } %} | ||
| </button> | ||
| <ul {{ bem('submenu', [], header__base_class ~ '__menu-item') }}> | ||
| {% for subitem in item.submenu %} | ||
| <li {{ bem('submenu-item', [], header__base_class) }}> | ||
| <a {{ bem('link', [], header__base_class ~ '__submenu-item') }} href="{{ subitem.url }}">{{ subitem.label }}</a> | ||
| </li> | ||
| {% endfor %} | ||
| </ul> | ||
| {% endif %} |
Collaborator
There was a problem hiding this comment.
The main menu should reflect what we already have here: https://deploy-preview-175--emulsify-ui-kit.netlify.app/?path=/story/components-navigation-main--main
mariannuar
added
👉 Needs Work
robherba
added
👍 Ready for Review
Contributor
|
All set @mariannuar!! |
mariannuar
approved these changes
May 31, 2026
mariannuar
left a comment
mariannuar
left a comment
Collaborator
There was a problem hiding this comment.
@robherba LGTM! Thanks
robherba
added
🎉 Passes Functional Review
robherba
changed the base branch from
main
to
emulsif-565--emulsify-core-4x-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets
https://fourkitchens.clickup.com/t/36718269/EMULSIF-305
Summary
Adds a header component
How to review this pull request