Skip to content

EMULSIF-487: Add SDC Slot Definitions to Components#180

Merged
mariannuar merged 2 commits into
mainfrom
EMULSIF-487
May 8, 2026
Merged

EMULSIF-487: Add SDC Slot Definitions to Components#180
mariannuar merged 2 commits into
mainfrom
EMULSIF-487

Conversation

@mariannuar
Copy link
Copy Markdown
Collaborator

@mariannuar mariannuar commented Apr 17, 2026

Tickets

https://fourkitchens.clickup.com/t/36718269/EMULSIF-487

Summary

Enhance our Single Directory Components implementation by explicitly defining slots in the components.yml file for components that use Twig blocks.

How to review this pull request

  • Please review the following components in Storybook:

    • Accordion
    • Tabs
    • Media Box
    • Text with Image
    • Card
    • Banner
    • Basic Elements
    • Button
    • Link
    • Image (Figure)
    • Video Embed
    • Typography (Text)
    • Text
    • Blockquote
    • Code
    • Lists
  • Confirm components render the same in Storybook

  • There should be no visual or functional changes

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 17, 2026

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 4468f14
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/69e28bbe0995740008224a6b
😎 Deploy Preview https://deploy-preview-180--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mariannuar mariannuar self-assigned this Apr 17, 2026
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Apr 17, 2026
@robherba robherba added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Apr 27, 2026
Copy link
Copy Markdown
Contributor

@robherba robherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @mariannuar! 🚀

@robherba robherba added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. and removed 👁 Review in progress Under review. labels Apr 28, 2026
@mariannuar mariannuar merged commit f108138 into main May 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants