Skip to content

EMULSIF-565: Upgrade Emulsify UI Kit to Emulsify Core 4.x#181

Open
robherba wants to merge 23 commits into
mainfrom
emulsif-565--emulsify-core-4x-upgrade
Open

EMULSIF-565: Upgrade Emulsify UI Kit to Emulsify Core 4.x#181
robherba wants to merge 23 commits into
mainfrom
emulsif-565--emulsify-core-4x-upgrade

Conversation

@robherba

@robherba robherba commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Ticket(s):

Summary

This PR upgrades the Emulsify UI Kit to Emulsify Core 4.x, replacing the legacy Webpack build with Vite and updating the project to Node 24.

Documentation update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this pull request

  1. Verify .nvmrc and package.json are configured to use Node 24.
  2. Confirm @emulsify/core has been upgraded to 4.x, Webpack references have been removed, and Vite scripts are in place.
  3. From a clean checkout, run:
    npm install
    npm run tokens:build
    npm run build
    Verify all commands complete successfully.
  4. Run npm run storybook and verify Storybook starts correctly, existing UI Kit components render as expected, and token-generated styles are applied.
  5. Run the following commands:
    npm run storybook-build
    npm run audit
    npm run audit:twig-stories
    npm run lint
    npm test
    npm run a11y
    Verify each command completes successfully, or document any existing unrelated issues.
  6. Verify the visual regression workflow, CI, and deployment pipelines continue to work using Node 24 and the updated build commands.

@robherba robherba self-assigned this Jun 8, 2026
@robherba robherba added the 🚧 Work in Progress The PR is a work in progress. label Jun 8, 2026
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit e2270f4
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/6a4579ee9b1b6c0008805786
😎 Deploy Preview https://deploy-preview-181--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

robherba added 18 commits June 16, 2026 14:12
@robherba robherba added 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels Jul 1, 2026
@mariannuar mariannuar added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Jul 11, 2026
@mariannuar

Copy link
Copy Markdown
Collaborator

@robherba Thank you very much for doing this work. It looks and works great!!! I just saw that when running npm run lint, we are getting some errors:

Screenshot 2026-07-11 at 2 23 36 PM

Besides that, I don't have any feedback from my side. Great work!

@mariannuar mariannuar added 👉 Needs Work Reviewer has requested changes. and removed 👁 Review in progress Under review. labels Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👉 Needs Work Reviewer has requested changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants