Codex/php84 compat tests#11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
8.4+.11.3+, PHP8.4+, and Drush13+expectations.8.4and8.5.ThemeNamespaceRegistryto better protect default Drupal module/theme Twig namespaces while allowing intentional namespace reuse.components.allow_default_namespace_reuseto opt into reusing an extension’s default namespace.components.namespaces.new Finder()usages to use PHP 8.4-compatible syntax without unnecessary wrapping parentheses.BemTwigExtension.TwigAttributeManager.SubThemeGenerator.ThemeNamespaceRegistry.Related Issue(s)
Notes:
release-2branch and assumes the Drupal11.3+, PHP8.4+, and Drush13+compatibility direction from that release line.components.allow_default_namespace_reuse.Functional Testing:
8.4+.8.4.composer install.11.3+site withdrush en emulsify_tools -y.drush cr.8.4.8.5.git ls-files '*.php' | xargs -n 1 php -l.BemTwigExtensionTestpasses.TwigAttributeManagerTestpasses.SubThemeGeneratorTestpasses.ThemeNamespaceRegistryTestpasses.drush emulsify "Test Theme".themes/custom/test_theme.test_theme.*.info.emulsify.ymlfile.components.namespacesentry to a test theme and confirm namespaced Twig templates still resolve correctly.components.allow_default_namespace_reuseto an extension and confirm its default namespace can be reused.components.namespacesand confirm that namespace reuse is allowed..twig,.html, and.svg..php, are rejected.Security
Security checks that should be reviewed
components.allow_default_namespace_reuseor a matching namespace definition.8.4+syntax changes do not alter runtime behavior beyond compatibility/readability improvements.Accessibility
Should this be checked for this feature?