Apply reset_sequences fixture where needed to limit slow down

Author: browniebroke

tests/conftest.py

@@ -7,25 +7,20 @@
 from django.core import management
 from django.core.management.color import no_style
 from django.db import connection
-from django.test import TestCase, TransactionTestCase
 
 
-@pytest.fixture(autouse=True)
-def _reset_sequences(request):
-    """Reset all database sequences so PKs start from 1 in each test.
+@pytest.fixture
+def reset_sequences():
+    """
+    Reset all database sequences so PKs start from 1.
 
     PostgreSQL sequences are non-transactional and persist across
-    TestCase's transaction rollbacks. This fixture ensures every test
-    gets predictable PKs starting from 1 regardless of execution order.
-    No-op on SQLite and skipped for tests that don't use the database.
+    TestCase's transaction rollbacks. Apply this fixture to test
+    classes that rely on hardcoded PKs to keep them predictable
+    regardless of execution order. No-op on SQLite.
     """
     if connection.vendor != 'postgresql':
         return
-    # Only run for tests that actually have database access.
-    if not (request.cls and issubclass(request.cls, (TestCase, TransactionTestCase))):
-        if 'db' not in request.fixturenames and 'transactional_db' not in request.fixturenames:
-            return
-
     table_names = set(connection.introspection.table_names())
     models = [m for m in apps.get_models() if m._meta.db_table in table_names]
     sql_list = connection.ops.sequence_reset_sql(no_style(), models)

tests/test_filters.py

@@ -459,6 +459,7 @@ class Meta:
         fields = '__all__'
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class SearchFilterM2MTests(TestCase):
     def setUp(self):
         # Sequence of title/text/attributes is:
@@ -657,6 +658,7 @@ class Meta:
         fields = '__all__'
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class OrderingFilterTests(TestCase):
     def setUp(self):
         # Sequence of title/text is:
@@ -974,6 +976,7 @@ class Meta:
         fields = ('id', 'user')
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class SensitiveOrderingFilterTests(TestCase):
     def setUp(self):
         for idx in range(3):

tests/test_generics.py

@@ -76,6 +76,7 @@ class SlugBasedInstanceView(InstanceView):
 
 
 # Tests
+@pytest.mark.usefixtures("reset_sequences")
 class TestRootView(TestCase):
     def setUp(self):
         """
@@ -171,6 +172,7 @@ def test_post_error_root_view(self):
 EXPECTED_QUERIES_FOR_PUT = 2
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestInstanceView(TestCase):
     def setUp(self):
         """
@@ -334,6 +336,7 @@ def setUp(self):
         self.view = FKInstanceView.as_view()
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestOverriddenGetObject(TestCase):
     """
     Test cases for a RetrieveUpdateDestroyAPIView that does NOT use the
@@ -477,6 +480,7 @@ class Meta:
         return DynamicSerializer
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestFilterBackendAppliedToViews(TestCase):
     def setUp(self):
         """

tests/test_model_serializer.py

@@ -758,6 +758,7 @@ class DisplayValueModel(models.Model):
     color = models.ForeignKey(DisplayValueTargetModel, on_delete=models.CASCADE)
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestRelationalFieldDisplayValue(TestCase):
     def setUp(self):
         DisplayValueTargetModel.objects.bulk_create([

tests/test_pagination.py

@@ -1045,6 +1045,7 @@ class CursorPaginationModel(models.Model):
     created = models.IntegerField()
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestCursorPaginationWithValueQueryset(CursorPaginationTestsMixin, TestCase):
     """
     Unit tests for `pagination.CursorPagination` for value querysets.

tests/test_permissions.py

@@ -2,6 +2,7 @@
 import unittest
 from unittest import mock
 
+import pytest
 from django.conf import settings
 from django.contrib.auth.models import AnonymousUser, Group, Permission, User
 from django.db import models
@@ -73,6 +74,7 @@ def basic_auth_header(username, password):
     return 'Basic %s' % base64_credentials
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class ModelPermissionsIntegrationTests(TestCase):
     def setUp(self):
         User.objects.create_user('disallowed', 'disallowed@example.com', 'password')
@@ -325,6 +327,7 @@ def get_queryset(self):
 get_queryset_object_permissions_view = GetQuerysetObjectPermissionInstanceView.as_view()
 
 
+@pytest.mark.usefixtures("reset_sequences")
 @unittest.skipUnless('guardian' in settings.INSTALLED_APPS, 'django-guardian not installed')
 class ObjectPermissionsIntegrationTests(TestCase):
     """
@@ -504,6 +507,7 @@ class DeniedObjectViewWithDetail(PermissionInstanceView):
 denied_object_view_with_detail = DeniedObjectViewWithDetail.as_view()
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class CustomPermissionsTests(TestCase):
     def setUp(self):
         BasicModel(text='foo').save()

tests/test_prefetch_related.py

@@ -1,3 +1,4 @@
+import pytest
 from django.contrib.auth.models import Group, User
 from django.test import TestCase
 
@@ -18,6 +19,7 @@ class UserUpdate(generics.UpdateAPIView):
     serializer_class = UserSerializer
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class TestPrefetchRelatedUpdates(TestCase):
     def setUp(self):
         self.user = User.objects.create(username='tom', email='tom@example.com')

tests/test_relations_hyperlink.py

@@ -69,6 +69,7 @@ class Meta:
         fields = ('url', 'name', 'nullable_source')
 
 
+@pytest.mark.usefixtures("reset_sequences")
 @override_settings(ROOT_URLCONF='tests.test_relations_hyperlink')
 class HyperlinkedManyToManyTests(TestCase):
     def setUp(self):
@@ -203,6 +204,7 @@ def test_data_cannot_be_accessed_prior_to_is_valid(self):
             serializer.data
 
 
+@pytest.mark.usefixtures("reset_sequences")
 @override_settings(ROOT_URLCONF='tests.test_relations_hyperlink')
 class HyperlinkedForeignKeyTests(TestCase):
     def setUp(self):
@@ -332,6 +334,7 @@ def test_foreign_key_update_with_invalid_null(self):
         assert serializer.errors == {'target': ['This field may not be null.']}
 
 
+@pytest.mark.usefixtures("reset_sequences")
 @override_settings(ROOT_URLCONF='tests.test_relations_hyperlink')
 class HyperlinkedNullableForeignKeyTests(TestCase):
     def setUp(self):

tests/test_relations_pk.py

@@ -95,6 +95,7 @@ class Meta:
         fields = '__all__'
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class PKManyToManyTests(TestCase):
     def setUp(self):
         for idx in range(1, 4):
@@ -226,6 +227,7 @@ def test_data_cannot_be_accessed_prior_to_is_valid(self):
             serializer.data
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class PKForeignKeyTests(TestCase):
     def setUp(self):
         target = ForeignKeyTarget(name='target-1')
@@ -415,6 +417,7 @@ class Meta:
         assert len(queryset) == 1
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class PKRelationTests(TestCase):
 
     def setUp(self):
@@ -443,6 +446,7 @@ def test_relation_field_property_source(self):
             self.assertEqual(serializer.data, expected)
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class PKNullableForeignKeyTests(TestCase):
     def setUp(self):
         target = ForeignKeyTarget(name='target-1')
@@ -559,6 +563,7 @@ def test_nullable_uuid_foreign_key_is_valid_when_none(self):
         assert serializer.is_valid(), serializer.errors
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class PKNullableOneToOneTests(TestCase):
     def setUp(self):
         target = OneToOneTarget(name='target-1')

tests/test_relations_slug.py

@@ -1,3 +1,4 @@
+import pytest
 from django.test import TestCase
 
 from rest_framework import serializers
@@ -42,6 +43,7 @@ class Meta:
 
 
 # TODO: M2M Tests, FKTests (Non-nullable), One2One
+@pytest.mark.usefixtures("reset_sequences")
 class SlugForeignKeyTests(TestCase):
     def setUp(self):
         target = ForeignKeyTarget(name='target-1')
@@ -182,6 +184,7 @@ def test_foreign_key_update_with_invalid_null(self):
         assert serializer.errors == {'target': ['This field may not be null.']}
 
 
+@pytest.mark.usefixtures("reset_sequences")
 class SlugNullableForeignKeyTests(TestCase):
     def setUp(self):
         target = ForeignKeyTarget(name='target-1')