The methods in the BasePermission class have incorrect return type inference

[hussein-m-kandil]

The has_permission and has_object_permission methods in the BasePermission class currently return True, which leads their return type to be inferred as Literal[True].

class BasePermission(metaclass=BasePermissionMetaclass):
    def has_permission(self, request, view):
        return True  # Inferred as `Literal[True]`
        
    def has_object_permission(self, request, view, obj):
        return True  # Inferred as `Literal[True]`

I suggest returning bool(True) from the methods so their return type is inferred as bool.

class BasePermission(metaclass=BasePermissionMetaclass):
    def has_permission(self, request, view):
        return bool(True)  # Inferred as `bool`
        
    def has_object_permission(self, request, view, obj):
        return bool(True)  # Inferred as `bool`

[Natgho]

Although it may seem like a valid reason, but writing bool(True) isn’t really in line with the Pythonic way. When a developer looks at the code, they might wonder, “Why not just True instead of bool(True)?” It feels like a workaround that disrupts the language’s natural flow.

there is a much simpler solution;

class BasePermission(metaclass=BasePermissionMetaclass):
    def has_permission(self, request, view) -> bool: # just adding type hint
        return True

Although it may seem like an insignificant extra step, the “bool(True)” operation in your solution involves a conversion. Specifically, it involves transitioning from a “pure” conversion to a constructor call.

If you create a pull request on this issue and proceed with the solution I suggested—in my opinion—you’ll be making a much more acceptable PR.

[hussein-m-kandil]

Of course, your suggestion would be much better, but I thought it might be an odd solution because I couldn't find any type hints in the permissions module. If the maintainers allow type hints, your suggestion would be perfect since this is a typing issue.