Fix #9750: Respect blank=True when applying uniqueness constraints#9951
Open
25punam wants to merge 2 commits intoencode:mainfrom
Open
Fix #9750: Respect blank=True when applying uniqueness constraints#995125punam wants to merge 2 commits intoencode:mainfrom
25punam wants to merge 2 commits intoencode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #9750
When a model field with blank=True participates in a UniqueConstraint,
ModelSerializer may incorrectly mark the field as required when no
default value is provided.
This change updates get_uniqueness_extra_kwargs() so that fields with
blank=True are treated as optional by setting required=False and
allow_blank=True.
This helps keep serializer behavior consistent with Django model
semantics, where blank=True indicates that the field is not required.