Skip to content

Fix #9750: Respect blank=True when applying uniqueness constraints #9951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
25punam wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #9750: Respect blank=True when applying uniqueness constraints #9951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f4a97
Fix #9750: Respect blank=True when applying uniqueness constraints
25punam Apr 7, 2026
6be1419
Fix #9750: Respect blank=True when applying uniqueness constraints
25punam Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions rest_framework/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,18 +1527,20 @@ def get_uniqueness_extra_kwargs(self, field_names, declared_fields, extra_kwargs
default = empty

if unique_constraint_name in model_fields:
# The corresponding field is present in the serializer
if default is empty:
uniqueness_extra_kwargs[unique_constraint_name] = {'required': True}
if getattr(unique_constraint_field, "blank", False):
uniqueness_extra_kwargs[unique_constraint_name] = {
"required": False,
"allow_blank": True,
}
else:
uniqueness_extra_kwargs[unique_constraint_name] = {"required": True}
else:
uniqueness_extra_kwargs[unique_constraint_name] = {'default': default}
uniqueness_extra_kwargs[unique_constraint_name] = {"default": default}

elif default is not empty:
# The corresponding field is not present in the
# serializer. We have a default to use for it, so
# add in a hidden field that populates it.
hidden_fields[unique_constraint_name] = HiddenField(default=default)

# Update `extra_kwargs` with any new options.

for key, value in uniqueness_extra_kwargs.items():
if key in extra_kwargs:
value.update(extra_kwargs[key])
Expand Down
Loading