not always h1

Author: soundofspace

httpcore/_async/connection.py

@@ -143,7 +143,11 @@ async def _connect(self, request: Request) -> AsyncNetworkStream:
                         if self._ssl_context is None
                         else self._ssl_context
                     )
-                    alpn_protocols = ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
+                    alpn_protocols = []
+                    if self._http2:
+                        alpn_protocols.append("h2")
+                    if self._http1:
+                        alpn_protocols.append("http/1.1")
                     ssl_context.set_alpn_protocols(alpn_protocols)
 
                     kwargs = {

httpcore/_async/http_proxy.py

@@ -304,7 +304,11 @@ async def handle_async_request(self, request: Request) -> Response:
                     if self._ssl_context is None
                     else self._ssl_context
                 )
-                alpn_protocols = ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
+                alpn_protocols = []
+                if self._http2:
+                    alpn_protocols.append("h2")
+                if self._http1:
+                    alpn_protocols.append("http/1.1")
                 ssl_context.set_alpn_protocols(alpn_protocols)
 
                 kwargs = {

httpcore/_async/socks_proxy.py

@@ -251,9 +251,11 @@ async def handle_async_request(self, request: Request) -> Response:
                             if self._ssl_context is None
                             else self._ssl_context
                         )
-                        alpn_protocols = (
-                            ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
-                        )
+                        alpn_protocols = []
+                        if self._http2:
+                            alpn_protocols.append("h2")
+                        if self._http1:
+                            alpn_protocols.append("http/1.1")
                         ssl_context.set_alpn_protocols(alpn_protocols)
 
                         kwargs = {

httpcore/_sync/connection.py

@@ -143,7 +143,11 @@ def _connect(self, request: Request) -> NetworkStream:
                         if self._ssl_context is None
                         else self._ssl_context
                     )
-                    alpn_protocols = ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
+                    alpn_protocols = []
+                    if self._http2:
+                        alpn_protocols.append("h2")
+                    if self._http1:
+                        alpn_protocols.append("http/1.1")
                     ssl_context.set_alpn_protocols(alpn_protocols)
 
                     kwargs = {

httpcore/_sync/http_proxy.py

@@ -304,7 +304,11 @@ def handle_request(self, request: Request) -> Response:
                     if self._ssl_context is None
                     else self._ssl_context
                 )
-                alpn_protocols = ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
+                alpn_protocols = []
+                if self._http2:
+                    alpn_protocols.append("h2")
+                if self._http1:
+                    alpn_protocols.append("http/1.1")
                 ssl_context.set_alpn_protocols(alpn_protocols)
 
                 kwargs = {

httpcore/_sync/socks_proxy.py

@@ -251,9 +251,11 @@ def handle_request(self, request: Request) -> Response:
                             if self._ssl_context is None
                             else self._ssl_context
                         )
-                        alpn_protocols = (
-                            ["h2", "http/1.1"] if self._http2 else ["http/1.1"]
-                        )
+                        alpn_protocols = []
+                        if self._http2:
+                            alpn_protocols.append("h2")
+                        if self._http1:
+                            alpn_protocols.append("http/1.1")
                         ssl_context.set_alpn_protocols(alpn_protocols)
 
                         kwargs = {