Skip to content

Commit e9785c8

Browse files
committed
use an assert for mypy None, rather than an if (for coverage)
1 parent cd45231 commit e9785c8

2 files changed

Lines changed: 8 additions & 16 deletions

File tree

httpcore/_async/http2.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -295,11 +295,9 @@ async def _receive_response(
295295
if isinstance(event, h2.events.ResponseReceived):
296296
break
297297

298-
if event.headers is None:
299-
return (200, [])
300-
301298
status_code = 200
302299
headers = []
300+
assert event.headers is not None
303301
for k, v in event.headers:
304302
if k == b":status":
305303
status_code = int(v.decode("ascii", errors="ignore"))
@@ -316,11 +314,9 @@ async def _receive_response_body(
316314
"""
317315
while True:
318316
event = await self._receive_stream_event(request, stream_id)
319-
if (
320-
isinstance(event, h2.events.DataReceived)
321-
and event.flow_controlled_length is not None
322-
and event.data is not None
323-
):
317+
if isinstance(event, h2.events.DataReceived):
318+
assert event.flow_controlled_length is not None
319+
assert event.data is not None
324320
amount = event.flow_controlled_length
325321
self._h2_state.acknowledge_received_data(amount, stream_id)
326322
await self._write_outgoing_data(request)

httpcore/_sync/http2.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -295,11 +295,9 @@ def _receive_response(
295295
if isinstance(event, h2.events.ResponseReceived):
296296
break
297297

298-
if event.headers is None:
299-
return (200, [])
300-
301298
status_code = 200
302299
headers = []
300+
assert event.headers is not None
303301
for k, v in event.headers:
304302
if k == b":status":
305303
status_code = int(v.decode("ascii", errors="ignore"))
@@ -316,11 +314,9 @@ def _receive_response_body(
316314
"""
317315
while True:
318316
event = self._receive_stream_event(request, stream_id)
319-
if (
320-
isinstance(event, h2.events.DataReceived)
321-
and event.flow_controlled_length is not None
322-
and event.data is not None
323-
):
317+
if isinstance(event, h2.events.DataReceived):
318+
assert event.flow_controlled_length is not None
319+
assert event.data is not None
324320
amount = event.flow_controlled_length
325321
self._h2_state.acknowledge_received_data(amount, stream_id)
326322
self._write_outgoing_data(request)

0 commit comments

Comments
 (0)