fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fix: handle http2 goaway race conditions

Author: Magd Bayoumi

httpcore/_async/http2.py

@@ -201,9 +201,9 @@ async def handle_async_request(self, request: Request) -> Response:
                         },
                     )
                     raise ConnectionGoingAway(
-                        self._connection_terminated,  # type: ignore[arg-type]
-                        last_stream_id=self._connection_terminated.last_stream_id,  # type: ignore[arg-type]
-                        error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                        self._connection_terminated,  # type: ignore[arg-type,unused-ignore]
+                        last_stream_id=self._connection_terminated.last_stream_id,  # type: ignore[arg-type,unused-ignore]
+                        error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                         request_stream_id=stream_id,
                         headers_sent=phase["headers_sent"],
                         body_sent=phase["body_sent"],
@@ -414,7 +414,7 @@ async def _receive_events(
                         raise ConnectionGoingAway(
                             f"GOAWAY received: stream {stream_id} > last_stream_id {last_stream_id}",
                             last_stream_id=last_stream_id,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],
@@ -426,7 +426,7 @@ async def _receive_events(
                             last_stream_id=last_stream_id
                             if last_stream_id is not None
                             else 0,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],
@@ -545,7 +545,7 @@ async def _read_incoming_data(
                         raise ConnectionGoingAway(
                             "Server disconnected after GOAWAY",
                             last_stream_id=last_stream_id if last_stream_id else 0,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],

httpcore/_sync/http2.py

@@ -201,9 +201,9 @@ def handle_request(self, request: Request) -> Response:
                         },
                     )
                     raise ConnectionGoingAway(
-                        self._connection_terminated,  # type: ignore[arg-type]
-                        last_stream_id=self._connection_terminated.last_stream_id,  # type: ignore[arg-type]
-                        error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                        self._connection_terminated,  # type: ignore[arg-type,unused-ignore]
+                        last_stream_id=self._connection_terminated.last_stream_id,  # type: ignore[arg-type,unused-ignore]
+                        error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                         request_stream_id=stream_id,
                         headers_sent=phase["headers_sent"],
                         body_sent=phase["body_sent"],
@@ -414,7 +414,7 @@ def _receive_events(
                         raise ConnectionGoingAway(
                             f"GOAWAY received: stream {stream_id} > last_stream_id {last_stream_id}",
                             last_stream_id=last_stream_id,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],
@@ -426,7 +426,7 @@ def _receive_events(
                             last_stream_id=last_stream_id
                             if last_stream_id is not None
                             else 0,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],
@@ -545,7 +545,7 @@ def _read_incoming_data(
                         raise ConnectionGoingAway(
                             "Server disconnected after GOAWAY",
                             last_stream_id=last_stream_id if last_stream_id else 0,
-                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type]
+                            error_code=self._connection_terminated.error_code,  # type: ignore[arg-type,unused-ignore]
                             request_stream_id=stream_id,
                             headers_sent=phase["headers_sent"],
                             body_sent=phase["body_sent"],