Disallow exact-name pairups for compiler-generated symbols

Author: LagoLunatic

objdiff-core/src/diff/data.rs

@@ -50,12 +50,11 @@ pub fn symbol_name_matches(left_name: &str, right_name: &str) -> bool {
         } else {
             false
         }
-    } else if let Some((prefix, suffix)) = left_name.split_once(['$', '.']) {
+    } else if let Some((prefix, suffix)) = left_name.split_once(['$', '.'])
+        && suffix.chars().all(char::is_numeric)
+    {
         // Match Metrowerks symbol$1234 against symbol$2345
         // and GCC symbol.1234 against symbol.2345
-        if !suffix.chars().all(char::is_numeric) {
-            return false;
-        }
         right_name
             .split_once(['$', '.'])
             .is_some_and(|(p, s)| p == prefix && s.chars().all(char::is_numeric))

objdiff-core/src/diff/mod.rs

@@ -760,13 +760,7 @@ fn find_symbol(
         return closest_match_symbol_idx;
     }
 
-    // Try to find an exact name match
-    if let Some((symbol_idx, _)) = unmatched_symbols(obj, used).find(|(_, symbol)| {
-        symbol.name == in_symbol.name && symbol_section_kind(obj, symbol) == section_kind
-    }) {
-        return Some(symbol_idx);
-    }
-
+    // Try to find a symbol with a matching name
     if let Some((symbol_idx, _)) = unmatched_symbols(obj, used)
         .filter(|&(_, symbol)| {
             symbol_name_matches(&in_symbol.name, &symbol.name)