Merge pull request #860 from endlessm/799-more-silly-wiring

dbnicholson · web-flow · commit df7008a910ab · 2023-09-28T10:51:00.000-06:00
Routing: Fix one more page mounting early
diff --git a/kolibri_explore_plugin/assets/src/modules/topicsRoot/handlers.js b/kolibri_explore_plugin/assets/src/modules/topicsRoot/handlers.js
@@ -215,9 +215,9 @@ export function decideDownload(store, grade, name) {
             });
           } else {
             console.debug('Conditions not met to download, assuming as completed.');
-            router.replace({ name: PageNames.TOPICS_ROOT });
             store.commit('CORE_SET_PAGE_LOADING', false);
             store.commit('CORE_SET_ERROR', null);
+            router.replace({ name: PageNames.TOPICS_ROOT });
           }
         });
       }

Original file line number	Diff line number	Diff line change
`@@ -215,9 +215,9 @@ export function decideDownload(store, grade, name) {`
`215`	`215`	`});`
`216`	`216`	`} else {`
`217`	`217`	`console.debug('Conditions not met to download, assuming as completed.');`
`218`		`- router.replace({ name: PageNames.TOPICS_ROOT });`
`219`	`218`	`store.commit('CORE_SET_PAGE_LOADING', false);`
`220`	`219`	`store.commit('CORE_SET_ERROR', null);`
	`220`	`+ router.replace({ name: PageNames.TOPICS_ROOT });`
`221`	`221`	`}`
`222`	`222`	`});`
`223`	`223`	`}`