Skip to content

Commit fe3b218

Browse files
committed
Migrate all card sliders to the new implementation
1 parent 53529cc commit fe3b218

7 files changed

Lines changed: 33 additions & 16 deletions

File tree

kolibri_explore_plugin/assets/src/components/EkIguanaList.vue

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,18 @@
1111
{{ name }}
1212
</h5>
1313
</b-container>
14-
<b-container class="no-container-padding">
15-
<EkSlidableGrid
14+
<b-container fluid class="no-container-padding">
15+
<EkSlidableGridNew
1616
v-slot="slotProps"
1717
:nodes="getSlidableGridNodes(channels, contentPicks)"
1818
:hasWhiteBackground="true"
1919
:itemsPerSlide="{ lg: 3, md: 2, sm: 1 }"
2020
>
21-
<template
22-
v-for="node in slotProps.slideNodes"
21+
<div
22+
v-for="(node, index) in slotProps.nodes"
23+
:key="node.id"
24+
class="slide"
25+
:index="index"
2326
>
2427
<EkChannelCard
2528
v-if="node !== undefined && node.kind === 'channel'"
@@ -32,8 +35,8 @@
3235
:key="node.id"
3336
:node="node"
3437
/>
35-
</template>
36-
</EkSlidableGrid>
38+
</div>
39+
</EkSlidableGridNew>
3740
</b-container>
3841
</div>
3942
</div>

kolibri_explore_plugin/assets/src/views/DiscoveryPageContenPacks.vue

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,31 @@
77
<EkCardGridPlaceholder />
88
</template>
99
<template v-else>
10-
<b-container class="mb-2 mt-4 no-container-padding">
10+
<b-container fluid class="mb-2 mt-4 no-container-padding">
1111
<template v-if="hasNodesForSection('featured-channel')">
1212
<b-container>
1313
<h5 class="mt-2 text-muted">
1414
{{ $tr('channelLabel') }}
1515
</h5>
1616
</b-container>
1717
<!-- These classes must match EkCardGrid -->
18-
<b-container class="mb-5 mt-3 no-container-padding section-container">
19-
<EkSlidableGrid
18+
<b-container fluid class="mb-5 mt-3 no-container-padding section-container">
19+
<EkSlidableGridNew
2020
v-slot="slotProps"
2121
:nodes="sectionNodes['featured-channel']"
2222
>
23-
<EkChannelCard
24-
v-for="node in slotProps.slideNodes"
23+
<div
24+
v-for="(node, index) in slotProps.nodes"
2525
:key="node.id"
26-
:channel="node"
27-
@click.native="goToChannel(node.id)"
28-
/>
29-
</EkSlidableGrid>
26+
class="slide"
27+
:index="index"
28+
>
29+
<EkChannelCard
30+
:channel="node"
31+
@click.native="goToChannel(node.id)"
32+
/>
33+
</div>
34+
</EkSlidableGridNew>
3035
</b-container>
3136
</template>
3237
<template v-if="hasNodesForSection('highlight')">
@@ -37,6 +42,7 @@
3742
</b-container>
3843
<EkCardGrid
3944
:nodes="sectionNodes['highlight']"
45+
variant="slidable-new"
4046
/>
4147
</template>
4248
<template v-if="hasNodesForSection('skill')">
@@ -47,6 +53,7 @@
4753
</b-container>
4854
<EkCardGrid
4955
:nodes="sectionNodes['skill']"
56+
variant="slidable-new"
5057
/>
5158
</template>
5259
<template v-if="hasNodesForSection('career')">
@@ -57,6 +64,7 @@
5764
</b-container>
5865
<EkCardGrid
5966
:nodes="sectionNodes['career']"
67+
variant="slidable-new"
6068
/>
6169
</template>
6270
<template v-if="hasNodesForSection('curious')">
@@ -67,6 +75,7 @@
6775
</b-container>
6876
<EkCardGrid
6977
:nodes="sectionNodes['curious']"
78+
variant="slidable-new"
7079
/>
7180
</template>
7281

packages/template-ui/src/components/EmptyResultsMessage.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<EkCardGrid
1919
v-if="showTopics"
2020
:nodes="mainSections"
21+
variant="slidable-new"
2122
:mediaQuality="mediaQuality"
2223
:cardColumns="cardColumns"
2324
>

packages/template-ui/src/views/Content.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
<EkCardGrid
3535
v-if="nextNodesInTopic.length && showNextContent"
3636
:nodes="nextNodesInTopic"
37+
variant="slidable-new"
3738
:cardColumns="cardColumns"
3839
class="next-grid"
3940
@nodeUpdated="onNextNodesUpdated"

packages/template-ui/src/views/Home.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<template v-if="contentNodes.nodes.length">
2727
<EkCardGrid
2828
:nodes="contentNodes.nodes"
29-
:variant="hasFlatGrid ? 'collapsible' : 'slidable'"
29+
:variant="hasFlatGrid ? 'collapsible' : 'slidable-new'"
3030
:mediaQuality="mediaQuality"
3131
:cardColumns="cardColumns"
3232
:hasMoreNodes="contentNodes.hasMoreNodes"
@@ -41,6 +41,7 @@
4141
<EkCardGrid
4242
:id="section.id"
4343
:nodes="sectionNodes[section.id].nodes"
44+
variant="slidable-new"
4445
:hasMoreNodes="sectionNodes[section.id].hasMoreNodes"
4546
:mediaQuality="mediaQuality"
4647
@loadMoreNodes="onLoadMoreSectionNodes(section.id)"

packages/template-ui/src/views/ListSection.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
v-for="subsection in sectionNodes.nodes"
2020
:id="subsection.id"
2121
:key="subsection.id"
22+
variant="slidable-new"
2223
:nodes="getSubsectionNodes(subsection.id).nodes"
2324
:mediaQuality="mediaQuality"
2425
:cardColumns="cardColumns"

packages/template-ui/src/views/Search.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
<EkCardGrid
3333
v-if="!resultNodes.length"
3434
:nodes="mainSections"
35+
variant="slidable-new"
3536
:mediaQuality="mediaQuality"
3637
:cardColumns="cardColumns"
3738
>

0 commit comments

Comments
 (0)