T34559 migrate to 16 alpha#520
Merged
Merged
Conversation
There is a new status_fn argument in the register_task decorator. And it's mandatory when long_running is True. Anyways long_running should be used for tasks that take more than 10 minutes. The status_fn argument was introduced in commit: a878c8b5 https://phabricator.endlessm.com/T34559
The RegisteredTask.validate_job_data() method now returns a tuple. This was changed at Kolibri commit: d4f545bc3fa https://phabricator.endlessm.com/T34559
The method was removed. https://phabricator.endlessm.com/T34559
This is needed for the following rebase of ContentItem. https://phabricator.endlessm.com/T34559
Rebease ContentItem with current one in Learn plugin. Also copy back the useContentNodeProgress and useProgressTracking composables https://phabricator.endlessm.com/T34559
dylanmccall
force-pushed
the
T34559-migrate-to-16-alpha
branch
from
3030995 to
d76212d
Compare
Collaborator
|
This all seems to be working on my end, including with the changes in endlessm/kolibri-installer-android#116. Feel free to merge whenever you'd like, @manuq, unless someone else would like to give it a review? :) |
Collaborator
Author
|
@dylanmccall all is working here as well, thanks! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T34559