Use Learn content viewer when available#526
Draft
manuq wants to merge 2 commits into
Draft
Conversation
manuq
force-pushed
the
T34740-content-viewer
branch
from
584729d to
6d84a1f
Compare
If the Learn plugin is present, build a URL with the content ID and navigate to it. Also pass the current location as URL parameter. If the Learn plugin can handle that parameter, it should use it to navigate back. If the Learn plugin is not present (no URL matching) display the content in a lightbox modal as before. https://phabricator.endlessm.com/T34740
manuq
force-pushed
the
T34740-content-viewer
branch
from
6d84a1f to
b13806f
Compare
Don't open the detail page in the custom channel presentation. Instead navigate to content. Which will show it in the Learn detail page if that plugin is available. https://phabricator.endlessm.com/T34740
Collaborator
Author
|
Asking for early feedback! Marking it again as draft because I don't think we want this until we sort out the Kolibri side. See ticket for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T34740