Draft: Filter unavailable in Channel view#621
Draft
GeorgesStavracas wants to merge 4 commits into
Draft
Conversation
Instead of using the global value for unavailable content unconditionally, receive that as an option, and use the global value as fallback.
Add a checkbox that is effectively equal to the one added to the Channel's search view. Changing the switch fetches the list of nodes again, passing the appropriate flag to KolibriApi. This is not optimal. One potential improvement is to always fetch unavailable content, and filter it within the view, but I've gone with this simpler approach given the time constraints.
Previous commit added the ability to filter out cards that are not available. That's good, we want that feature. What we don't want is empty sections with just the title, after all cards have been filtered out :) Hide empty sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready.
#569