-
Notifications
You must be signed in to change notification settings - Fork 4
New carousel cards #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
manuq
wants to merge
7
commits into
master
Choose a base branch
from
new-carousel-cards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New carousel cards #685
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4c229b7
Add vue-ssr-carousel dependency
manuq 831d1d7
Theme: Expose gutter to JS
manuq 2f1594c
Components: Add new card slider components
manuq 8b0edfa
Add "slidable-new" card grid variant
manuq 53529cc
template-ui: Add showcase for new slider
manuq fe3b218
Migrate all card sliders to the new implementation
manuq 9e80711
EkCardGrid: Use simple grid if no pagination
manuq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
packages/ek-components/src/components/EkSlidableCardGridNew.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <template> | ||
| <EkSlidableGridNew | ||
| v-slot="slotProps" | ||
| class="pb-4" | ||
| :nodes="nodes" | ||
| :hasMoreNodes="hasMoreNodes" | ||
| :itemsPerSlide="itemsPerSlide" | ||
| @loadMoreNodes="$emit('loadMoreNodes')" | ||
| > | ||
| <div | ||
| v-for="(node, index) in slotProps.nodes" | ||
| :key="node.id" | ||
| class="slide" | ||
| :index="index" | ||
| > | ||
| <EkCard | ||
| :node="node" | ||
| :mediaQuality="mediaQuality" | ||
| @nodeUpdated="onNodeUpdated" | ||
| /> | ||
| </div> | ||
| </EkSlidableGridNew> | ||
| </template> | ||
|
|
||
| <script> | ||
| import { ItemsPerSlide, MediaQuality } from '../constants'; | ||
| import { validateItemsPerSlide } from '../utils'; | ||
|
|
||
| export default { | ||
| name: 'EkSlidableCardGridNew', | ||
| props: { | ||
| nodes: { | ||
| type: Array, | ||
| required: true, | ||
| }, | ||
| hasMoreNodes: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, | ||
| mediaQuality: { | ||
| type: String, | ||
| default: MediaQuality.REGULAR, | ||
| }, | ||
| itemsPerSlide: { | ||
| type: Object, | ||
| default: () => ItemsPerSlide, | ||
| validator: validateItemsPerSlide, | ||
| }, | ||
| }, | ||
| methods: { | ||
| onNodeUpdated(nodeId) { | ||
| this.$emit('nodeUpdated', nodeId); | ||
| }, | ||
| }, | ||
| }; | ||
| </script> |
74 changes: 74 additions & 0 deletions
74
packages/ek-components/src/components/EkSlidableGridNew.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <template> | ||
| <b-container fluid class="no-container-padding" style="overflow: hidden"> | ||
| <b-container> | ||
| <SsrCarousel | ||
| :key="nodes.length" | ||
| v-model="slide" | ||
| :gutter="gridGutterWidth" | ||
| :slidesPerPage="itemsPerSlideComputed" | ||
| overflowVisible | ||
| paginateBySlide | ||
| @change="onChange" | ||
| > | ||
| <slot :nodes="nodes"></slot> | ||
| </SsrCarousel> | ||
| </b-container> | ||
| </b-container> | ||
| </template> | ||
|
|
||
| <script> | ||
| import SsrCarousel from 'vue-ssr-carousel'; | ||
| import { ItemsPerSlide } from '../constants'; | ||
| import { validateItemsPerSlide } from '../utils'; | ||
| import { gridGutterWidth } from '../styles.scss'; | ||
| import responsiveMixin from './mixins/responsiveMixin'; | ||
|
|
||
| export default { | ||
| name: 'EkSlidableGridNew', | ||
| components: { SsrCarousel }, | ||
| mixins: [responsiveMixin], | ||
| props: { | ||
| nodes: { | ||
| type: Array, | ||
| required: true, | ||
| }, | ||
| hasMoreNodes: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, | ||
| itemsPerSlide: { | ||
| type: Object, | ||
| default: () => ItemsPerSlide, | ||
| validator: validateItemsPerSlide, | ||
| }, | ||
| }, | ||
| data() { | ||
| return { | ||
| slide: 0, | ||
| gridGutterWidth, | ||
| }; | ||
| }, | ||
| computed: { | ||
| itemsPerSlideComputed() { | ||
| if (this.xs) { | ||
| return this.itemsPerSlide.sm; | ||
| } | ||
| if (this.sm || this.md) { | ||
| return this.itemsPerSlide.md; | ||
| } | ||
| return this.itemsPerSlide.lg; | ||
| }, | ||
| }, | ||
| methods: { | ||
| onChange({ index }) { | ||
| const isLastSlide = index >= this.nodes.length - this.itemsPerSlideComputed; | ||
| if (this.hasMoreNodes && isLastSlide) { | ||
| this.$emit('loadMoreNodes'); | ||
| } | ||
| }, | ||
| }, | ||
| } | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we choose a better name for these components?
EkSlidableGridvsEkSlidableGridNewhas zero meaning for someone who was not around when they were created. I tried to think of some suggestions and the best I could come up with wasEkInertialSlidableGrid, but I'm not sure how good that is.