Feedback form: Add hidden fields#869
Open
manuq wants to merge 1 commit into
Open
Conversation
manuq
force-pushed
the
868-hidden-form-fields
branch
from
ebec6cc to
4d192b1
Compare
Collaborator
Author
|
Ready for review. It will still say "Unknown" for platform but the rest is working and it's better than nothing. |
Add current language, current project and Kolibri and Endless Key versions as hidden fields. In the format accepted by Typeform. Helps #868
manuq
force-pushed
the
868-hidden-form-fields
branch
from
4d192b1 to
604ef47
Compare
dbnicholson
reviewed
Oct 7, 2023
Member
dbnicholson
left a comment
dbnicholson
left a comment
There was a problem hiding this comment.
Makes sense to me, although I don't really understand how the key version is gathered.
| } | ||
| }, | ||
| getBuildInfo() { | ||
| const buildInfo = urls.static(`build-info.json`); |
| feedbackUrl() { | ||
| const hiddenFormFields = new URLSearchParams({ | ||
| language: currentLanguage, | ||
| kolibriVersion: window.kolibriCoreAppGlobal.version, |
Member
There was a problem hiding this comment.
Should the explore version also be included here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #868