Skip to content

Get collections from the latest release#152

Open
dylanmccall wants to merge 3 commits into
developfrom
use-collections-from-release
Open

Get collections from the latest release#152
dylanmccall wants to merge 3 commits into
developfrom
use-collections-from-release

Conversation

@dylanmccall
Copy link
Copy Markdown

@dylanmccall dylanmccall commented Jun 15, 2023

Instead of downloading collections from the newest commit, use the most recent release from endless-key-collections.

endlessm/kolibri-explore-plugin#610

Instead of downloading collections from the newest commit, use the most
recent release from endless-key-collections.
@dylanmccall dylanmccall force-pushed the use-collections-from-release branch from 8512ff6 to e41b2a3 Compare June 20, 2023 01:36
@dylanmccall dylanmccall marked this pull request as ready for review June 20, 2023 01:37
@starnight
Copy link
Copy Markdown

bot test

Comment thread Makefile
Fixes commit e41b2a3 ("Get collections from the latest release").
@starnight
Copy link
Copy Markdown

It can get the correct URL for COLLECTIONS_TARBALL_URL.

But, there comes another error:

Saving to: 'collections.tar.gz'

     0K .......... .......... .......                          3.77M=0.007s

2023-06-20 06:42:54 (3.77 MB/s) - 'collections.tar.gz' saved [27726]

mkdir -p src/collections
tar -xz -f collections.tar.gz -C src/collections --overwrite '*/json/*.json' --strip-components=2
tar: Pattern matching characters used in file names
tar: Use --wildcards to enable pattern matching, or --no-wildcards to suppress this warning
tar: */json/*.json: Not found in archive
tar: Exiting with failure status due to previous errors

@starnight
Copy link
Copy Markdown

starnight commented Jun 20, 2023

Fixed by commit ("fixup! Get collections from the latest release")

@starnight
Copy link
Copy Markdown

starnight commented Jun 20, 2023

@dylanmccall Please help review the modification again :)

@starnight starnight self-requested a review June 20, 2023 13:37
@dbnicholson
Copy link
Copy Markdown
Member

Given that the collection JSON files are now published at https://endlessm.github.io/endless-key-collections, I think we should just wait until the explore plugin is fetching them at runtime and use #150 instead of adding more code for this intermediate state.

@dylanmccall
Copy link
Copy Markdown
Author

dylanmccall commented Jun 20, 2023

Ah, thank you for fixing those errors @starnight! Yeah, the reason for this change is to get a workflow in place for versioning endless-key-collections in order limit the amount of stuff that changes from endlessm/kolibri-explore-plugin#610. That's because I don't think we should release that explore plugin change until July. But if you're happy with what we have for the time being, I'm fine with that too - feel free to close this, and we can revert endlessm/endless-key-app#124 to keep things consistent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants