Don't share collision shapes between instances of platforms#51
Merged
Conversation
Loading and saving platform.tscn, without modification, causes these changes to be written to disk. The platform width change is because the default width in the script is 2 tiles, but the scene was set up for 3 tiles.
Previously, the collision shapes were shared between each instance of the scene. This means that if you placed 2 platforms in a scene, and set one of them to be 2 tiles wide and the other to 3 tiles wide, the collision shapes would both be as wide as the last platform in the scene tree, rather than matching their visible size. Making the resources local_to_scene causes them to be duplicated when the scene is instanced.
|
Play this branch at https://endlessm.github.io/moddable-platformer/branches/endlessm/platform-dont-share-collision-shapes. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Nov 25, 2025
|
|
||
| [sub_resource type="RectangleShape2D" id="RectangleShape2D_i4vtk"] | ||
| size = Vector2(384, 40) | ||
| resource_local_to_scene = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the collision shapes were shared between each instance of the scene.
This means that if you placed 2 platforms in a scene, and set one of them to be 2 tiles wide and the other to 3 tiles wide, the collision shapes would both be as wide as the last platform in the scene tree, rather than matching their visible size.
Making the resources local_to_scene causes them to be duplicated when the scene is instanced.