Skip to content

Commit 4463c40

Browse files
committed
Void runner: Only reveal thread once Void is pushed back
1 parent dca6cb4 commit 4463c40

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

scenes/game_elements/props/collectible_item/components/collectible_item.gd

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func reveal() -> void:
8080
revealed = true
8181
appear_sound.play()
8282
animation_player.play("reveal")
83+
await animation_player.animation_finished
8384

8485

8586
## When interacted with, the collectible will display a brief animation

scenes/quests/lore_quests/quest_002/1_void_runner/components/monk.gd

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ extends NPC
77
@export var camera: Camera2D
88
@export var void_layer: TileMapCover
99
@export var enemy: CharacterBody2D
10+
@export var collectible_thread: CollectibleItem
1011

1112
var _repelled := false
1213

@@ -20,6 +21,8 @@ func repel_void() -> void:
2021
await tween.finished
2122
await void_layer.uncover_all(3.0)
2223

24+
await collectible_thread.reveal()
25+
2326
tween = create_tween()
2427
tween.tween_property(camera, "zoom", original_zoom, 1.0).set_ease(Tween.EASE_IN_OUT)
2528
await tween.finished

scenes/quests/lore_quests/quest_002/1_void_runner/void_runner.tscn

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -849,15 +849,17 @@ polygon = PackedVector2Array(-221.5, 55.5, -226.5, 102.5, -174.5, 105.5, -158.5,
849849

850850
[node name="CollectibleItem" parent="OnTheGround" instance=ExtResource("22_auh5r")]
851851
position = Vector2(474, 1058)
852+
revealed = false
852853
next_scene = "uid://b8mfigsd8y5qs"
853854
item = SubResource("Resource_8l6e1")
854855
collected_dialogue = ExtResource("27_g2rto")
855856

856-
[node name="Monk" parent="OnTheGround" node_paths=PackedStringArray("camera", "void_layer", "enemy") instance=ExtResource("23_swnl7")]
857+
[node name="Monk" parent="OnTheGround" node_paths=PackedStringArray("camera", "void_layer", "enemy", "collectible_thread") instance=ExtResource("23_swnl7")]
857858
position = Vector2(3842, 1882)
858859
camera = NodePath("../Player/Camera2D")
859860
void_layer = NodePath("../../TileMapLayers/Void")
860861
enemy = NodePath("../VoidSpreadingEnemy")
862+
collectible_thread = NodePath("../CollectibleItem")
861863

862864
[node name="UnreachableIsland1" type="Node2D" parent="OnTheGround"]
863865
y_sort_enabled = true

0 commit comments

Comments
 (0)