Do not assume class of first node in group player (#2369)

So cinematics can assign "player" group to the mock player sprite.

This makes the dialogue balloon to appear at the top of the screen when
the
sprite is at the bottom.

### Do not assume class of first node in group player

Certain scripts could treat player as a CharacterBody2D for physics,
as a Node2D for its position, or as a CanvasItem for visual stuff, etc.

Input HUD: It considers the player a CharacterBody2D and checks for its
components using `Object.get(COMPONENT_NAME) as COMPONENT_CLASS`.
Previously it
was assuming that the output of `get_first_node_in_group()` was a
CharacterBody2D. The assignment would fail if the first node in group
"player"
is of another type. This doesn't allow mock players, for example an
AnimatedSprite2D in a cinematic.

Throwing enemy: All this enemy needs is the global_position of player
for
throwing. This makes it closer to the ThrowProjectileBehavior which has
`@export
var target: Node2D`. Also get the player node from group "player" only
once.

player_follower.gd: All this script needs is the global_position of
player
for calculating the offset.

----

Fix #2306

Author: manuq

scenes/game_elements/characters/enemies/throwing_enemy/components/throwing_enemy.gd

@@ -129,6 +129,7 @@ var allowed_labels: Array[String] = ["???"]
 ## color-matching game.
 var color_per_label: Dictionary[String, Color]
 
+var _player: Node2D
 var _initial_position: Vector2
 var _target_position: Vector2
 var _is_attacking: bool
@@ -171,10 +172,10 @@ func _ready() -> void:
 	_set_sprite_frames(sprite_frames)
 	if Engine.is_editor_hint():
 		return
-	var player: Player = get_tree().get_first_node_in_group("player")
-	if is_instance_valid(player):
+	_player = get_tree().get_first_node_in_group("player") as Node2D
+	if is_instance_valid(_player):
 		var direction: Vector2 = projectile_marker.global_position.direction_to(
-			player.global_position
+			_player.global_position
 		)
 		scale.x = 1 if direction.x < 0 else -1
 	if autostart:
@@ -261,21 +262,19 @@ func _set_target_position() -> void:
 
 
 func _on_timeout() -> void:
-	var player: Player = get_tree().get_first_node_in_group("player")
-	if not is_instance_valid(player):
+	if not is_instance_valid(_player):
 		return
 	_is_attacking = true
 	animation_player.play(&"attack")
 	animation_player.queue(&"idle")
 
 
 func shoot_projectile() -> void:
-	var player: Player = get_tree().get_first_node_in_group("player")
 	if not allowed_labels:
 		_is_attacking = false
 		return
 
-	if shoot_projectile_at(player):
+	if shoot_projectile_at(_player):
 		_set_target_position()
 		_is_attacking = false
 

scenes/game_elements/props/player_follower/player_follower.gd

@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: MPL-2.0
 extends PathFollow2D
 
-@onready var player: Player = get_tree().get_first_node_in_group("player")
+@onready var player := get_tree().get_first_node_in_group("player") as Node2D
 
 
 func _process(_delta: float) -> void:

scenes/game_elements/props/spawn_point/components/spawn_point.gd

@@ -26,7 +26,7 @@ func _ready() -> void:
 
 
 func move_player_to_self_position(smooth_camera: bool = false) -> void:
-	var player: Node2D = get_tree().get_first_node_in_group("player")
+	var player := get_tree().get_first_node_in_group("player") as Node2D
 
 	if is_instance_valid(player):
 		player.teleport_to(self.global_position, smooth_camera, look_at_side_on_spawn)

scenes/globals/pause/pause_overlay.gd

@@ -72,7 +72,7 @@ func _on_abandon_quest_pressed() -> void:
 	)
 	await Transitions.finished
 
-	var player: Node2D = get_tree().get_first_node_in_group("player")
+	var player := get_tree().get_first_node_in_group("player") as Node2D
 	var replaying := quest in GameState.global.completed_quests
 	var title := "abandoned_replay" if replaying else "abandoned"
 	DialogueManager.show_dialogue_balloon(abandon_dialogue, title, [player])

scenes/quests/story_quests/champ/0_intro/champ_intro.tscn

@@ -218,7 +218,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=1029059295]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=1995106097]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=1995106097 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("3_ufx21")
 animation = &"idle"

scenes/quests/story_quests/champ/4_outro/champ_outro.tscn

@@ -52,7 +52,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=484328888]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=34892077]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=34892077 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("3_276wt")
 animation = &"idle"

scenes/quests/story_quests/el_abrigo/0_el_abrigo_intro/el_abrigo_intro.tscn

@@ -178,7 +178,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=117602598]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=577377136]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=577377136 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("3_p845x")
 animation = &"idle"

scenes/quests/story_quests/el_abrigo/4_el_abrigo_outro/el_abrigo_outro.tscn

@@ -88,7 +88,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=120484108]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=735842756]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=735842756 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("3_7j76p")
 animation = &"idle"

scenes/quests/story_quests/el_juguete_perdido/0_intro/intro.tscn

@@ -182,7 +182,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=101635259]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=190991224]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=190991224 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("10_nf7lg")
 animation = &"idle"

scenes/quests/story_quests/el_juguete_perdido/4_outro/outro.tscn

@@ -130,7 +130,7 @@ editor_draw_limits = true
 [node name="OnTheGround" type="Node2D" parent="." unique_id=1697789778]
 y_sort_enabled = true
 
-[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=1591226122]
+[node name="Character" type="AnimatedSprite2D" parent="OnTheGround" unique_id=1591226122 groups=["player"]]
 position = Vector2(400, 349)
 sprite_frames = ExtResource("12_ij0xq")
 animation = &"idle"