Adding townie walk animations broke character_randomizer_test interactions

[wjt]

Threadbare version

v0.1.11-58-g754e68efb

Affected scene

res://scenes/game_elements/characters/components/character_randomizer_test.tscn

Description

I bisected this bug to commit 754e68e.

Since this commit, if you play character_randomizer_test.tscn and interact with a townie, no dialogue plays, but the player is stuck in "interacting" mode and stops being able to move.

Checklist

• I've reviewed and agree to follow the code of conduct

[wjt]

I've been looking at this because I thought it was a regression in #2114 but it's pre-existing.

I think the problem is that the townie who follows you around now has an InteractArea but no TalkBehavior.

[manuq]

I've been looking at this because I thought it was a regression in #2114 but it's pre-existing.

I think the problem is that the townie who follows you around now has an InteractArea but no TalkBehavior.

Ouch my bad! Good finding. Indeed is that, I just checked removing the InteractArea and the regression is gone. Thanks for the bisect! Fix coming.

[wjt]

BTW I think this is one reason why interact + dialogue should be built-in to townie.tscn: it's error-prone to add the InteractArea by hand. (The other reason is that the more of them we have, the harder changes like #2150 are to make.) But I don't want to make that change while we are (both!) working heavily on this part of the code base.